exception handling

Author: gowrishankar95

UserManagement/src/main/java/com/hms/management/dao/UserRepository.java

@@ -6,7 +6,7 @@
 
 public interface UserRepository {
 
-    public void create(User user);
+    public User create(User user);
 
     public String updatePassword(int UserId, String oldPassword, String newPassword);
 

UserManagement/src/main/java/com/hms/management/dao/impl/UserRepositoryImpl.java

@@ -4,7 +4,6 @@
 import com.hms.management.UserMapper;
 import com.hms.management.dao.UserRepository;
 import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.beans.factory.annotation.Qualifier;
 import org.springframework.jdbc.core.JdbcTemplate;
 import org.springframework.stereotype.Repository;
 
@@ -16,17 +15,18 @@ public class UserRepositoryImpl implements UserRepository {
     private JdbcTemplate jdbcTemplate;
 
     @Override
-    public void create(User user) {
+    public User create(User user) {
         String sql = "INSERT INTO users (userName,passowrd) VALUES (?, ?)";
         jdbcTemplate.update(sql,user.getUsername(),user.getPassword());
+        return user;
 
     }
 
     @Override
     public String deleteUser(int id) {
         User user = isIdExist(id);
         if (user == null) {
-            System.out.println("User with id "+id+" not found");
+            System.out.println("User with id " + id + " not found");
             return "User with id "+id+" not found";
         } else {
             String sql = "DELETE  FROM users  WHERE UserId=?";

UserManagement/src/main/java/com/hms/management/rest/Exceptions/InvalidNameException.java

@@ -0,0 +1,4 @@
+package com.hms.management.rest.Exceptions;
+
+public class InvalidNameException extends  RuntimeException {
+}

UserManagement/src/main/java/com/hms/management/rest/Exceptions/InvalidPasswordException.java

@@ -0,0 +1,4 @@
+package com.hms.management.rest.Exceptions;
+
+public class InvalidPasswordException extends RuntimeException {
+}

UserManagement/src/main/java/com/hms/management/rest/UserManagementRestController.java

@@ -1,8 +1,9 @@
 package com.hms.management.rest;
 import com.hms.management.User;
 import com.hms.management.dao.UserRepository;
+import com.hms.management.rest.Exceptions.InvalidNameException;
+import com.hms.management.rest.Exceptions.InvalidPasswordException;
 import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.beans.factory.annotation.Qualifier;
 import org.springframework.web.bind.annotation.*;
 import java.util.List;
 
@@ -16,38 +17,29 @@ public void setUserRepository(UserRepository userRepository) {
         this.userRepository = userRepository;
     }
 
-    @GetMapping(value = "/Users")
-    public List<User> viewUsers() {
+    @GetMapping(value = "/users")
+    public List<User> getUserList() {
         return userRepository.viewAllUsers();
 
     }
 
-    @PostMapping("/Users")
-    public Object createUsers(@RequestParam(value = "userName", defaultValue = " ") String userName,
-                              @RequestParam(value = "password", defaultValue = " ") String password) {
+    @PostMapping("/users")
+    public Object createUser(@RequestParam(value = "userName", defaultValue = " ") String userName,
+                                     @RequestParam(value = "password", defaultValue = " ") String password) {
 
         User user = new User(userName, password);
 
-        if (user.getUsername().trim().isEmpty()) {
-            System.out.println("name is epmty");
-            return "empty name";
-        } else if (user.getUsername().trim().length() > 20) {
-            System.out.println("name cannot exceed 20 characters");
-            return "name cannot exceed 20 characters";
-        } else if (user.getPassword().trim().isEmpty()) {
-            System.out.println("password is epmty");
-            return "password is epmty";
-        } else if (user.getPassword().length() > 20) {
-            System.out.println("password cannot exceed 20 characters");
-            return "password cannot exceed 20 characters";
+        if (user.getUsername().trim().isEmpty() || user.getUsername().trim().length() > 20) {
+            throw new InvalidNameException();
+        } else if (user.getPassword().trim().isEmpty() || user.getPassword().length() > 20) {
+            throw new InvalidPasswordException();
         } else {
-            userRepository.create(user);
-            return "created new user";
+            return userRepository.create(user);
         }
 
     }
 
-    @PutMapping("/Users")
+    @PutMapping("/users")
     public Object updatePassword(@RequestParam(value = "id", defaultValue = " ") int id,
                                  @RequestParam(value = "opassword", defaultValue = " ") String oldPassword,
                                  @RequestParam(value = "npassword", defaultValue = " ") String newPassword) {
@@ -56,7 +48,7 @@ public Object updatePassword(@RequestParam(value = "id", defaultValue = " ") int
 
     }
 
-    @DeleteMapping("/Users")
+    @DeleteMapping("/users")
     public String deleteUser(@RequestParam(value = "id", defaultValue = " ") int id) {
 
         return userRepository.deleteUser(id);

UserManagement/src/main/java/com/hms/management/rest/UserManagementRestControllerExceptionHandler.java

@@ -0,0 +1,41 @@
+package com.hms.management.rest;
+
+import com.hms.management.rest.Exceptions.InvalidNameException;
+import com.hms.management.rest.Exceptions.InvalidPasswordException;
+import org.aspectj.lang.annotation.Before;
+import org.springframework.http.HttpStatus;
+import org.springframework.http.ResponseEntity;
+import org.springframework.web.bind.annotation.ControllerAdvice;
+import org.springframework.web.bind.annotation.ExceptionHandler;
+import org.springframework.web.bind.annotation.ResponseBody;
+
+import java.util.HashMap;
+import java.util.Map;
+
+@ControllerAdvice
+public class UserManagementRestControllerExceptionHandler {
+    @ResponseBody
+    @ExceptionHandler(value = InvalidNameException.class)
+    public Map<String,String> invalidUserNameException(){
+        Map<String,String> map = new HashMap<String, String>() ;
+        map.put("status",HttpStatus.NOT_FOUND.toString());
+        map.put("error","invalid user name. please enter a valid user name");
+
+         return map;
+
+    }
+
+    @ResponseBody
+    @ExceptionHandler(value = InvalidPasswordException.class)
+    public Map<String,String> invalidUserPasswordException(){
+        Map<String,String> map = new HashMap<String, String>() ;
+        map.put("status",HttpStatus.NOT_FOUND.toString());
+        map.put("error","invalid password. please enter a valid password less than 20 characters");
+
+        return map;
+
+    }
+
+
+}
+