fix(Table): add ability to redefine max height for menu popup#2612
fix(Table): add ability to redefine max height for menu popup#2612
Conversation
|
🎭 Component Tests Report is ready. |
7ced288 to
88f9747
Compare
|
Preview is ready. |
|
@leushin Hi! Could you please explain what issue is being addressed in this pull request? |
We have a case where important menu items are hidden behind a scroll, making it unclear to users that there is anything else there. These changes allow you to disable the maximum height for the entire menu and set the required minimum height. This way, you can customize the display of the table's menu actions: show everything without hiding it behind a scroll, or stretch it to the desired number of menu items. |
|
@leushin Adding two new props here makes the component API a bit heavier, and it looks like these are purely styling concerns rather than behavior. |
I don't want to redefine the component's CSS class by its generated name, as it may change and cause issues in the final service. Moreover, the element itself is located in a portal, so the redefinition will need to be done globally. CSS API is not used in the component, but it could be a solution (put 200px in a variable and override it at the service level) Therefore, you can try to switch to the CSS API at least in this place, although I don't see it being used anywhere. Alternatively, I will ask you to expand the API to at least one method. |
|
@leushin When I say “CSS API”, I mean exposing styling controls via documented CSS custom properties (CSS variables) that the component itself reads, rather than overriding generated class names. Yes, |
88f9747 to
b937b0e
Compare
Updated the PR, please take a look |
No description provided.