Skip to content

First pass at Grpc.StatusProto API #2205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesNK merged 15 commits into from
Jan 4, 2024
Merged

First pass at Grpc.StatusProto API #2205

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
85f7a57
First pass at Grpc.StatusProto API
tonydnewell Jul 21, 2023
ef2ec28
Updated README.md
tonydnewell Jul 25, 2023
83d11ef
Update from review comments
tonydnewell Aug 15, 2023
1a94ae0
Update from review comments
tonydnewell Aug 31, 2023
5314bd6
Fix tests on net472
tonydnewell Aug 31, 2023
3b57cac
Fix framework tests
tonydnewell Sep 2, 2023
f88a84c
Update from review comments
tonydnewell Sep 7, 2023
a032c7a
Merge branch 'grpc:master' into grpc.statuspro
tonydnewell Sep 7, 2023
46e482a
Add cache to RpcStatusExtensions
tonydnewell Sep 7, 2023
d5449f5
Update from review comments
tonydnewell Sep 12, 2023
5236b2e
Added TODO comment to StandardErrorTypeRegistry
tonydnewell Sep 26, 2023
9b94477
Update src/Grpc.StatusProto/README.md
tonydnewell Oct 19, 2023
956ad47
Merge branch 'grpc:master' into grpc.statuspro
tonydnewell Nov 9, 2023
d8a9228
Just merging from master
tonydnewell Jan 3, 2024
b052f31
Updating from review
tonydnewell Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests on net472
  • Loading branch information
@tonydnewell
tonydnewell committed Aug 31, 2023
commit 5314bd6d5ddc8294fd3858344797fa731d659ac0
36 changes: 29 additions & 7 deletions test/Grpc.StatusProto.Tests/ExceptionExtensionsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
// limitations under the License.
#endregion

using System.Text;
using Google.Rpc;
using NUnit.Framework;

namespace Grpc.StatusProto.Tests;
Expand All @@ -36,9 +38,13 @@ public void ToRpcDebugInfoTest()
var debugInfo = ex.ToRpcDebugInfo();
Assert.IsNotNull(debugInfo);
Assert.AreEqual("System.ArgumentException: extra details", debugInfo.Detail);
Assert.IsTrue(debugInfo.StackEntries.Count >= 2);
Assert.IsTrue(debugInfo.StackEntries[0].Contains("ExceptionExtensionsTest.ThrowException"));
Assert.IsTrue(debugInfo.StackEntries[1].Contains("ExceptionExtensionsTest.ToRpcDebugInfoTest"));

var stackTraces = ConcatStackTraces(debugInfo);
Console.WriteLine("Test stack trace data:");
Console.WriteLine(stackTraces);
Assert.IsTrue(stackTraces.Contains("ExceptionExtensionsTest.ThrowException"));
Assert.IsTrue(stackTraces.Contains("ExceptionExtensionsTest.ToRpcDebugInfoTest"));
Assert.IsFalse(stackTraces.Contains("InnerException:"));
}
}

Expand All @@ -54,10 +60,14 @@ public void ToRpcDebugInfo_WithInnerExceptionTest()
var debugInfo = ex.ToRpcDebugInfo(1);
Assert.IsNotNull(debugInfo);
Assert.AreEqual("System.ArgumentException: extra details", debugInfo.Detail);
Assert.IsTrue(debugInfo.StackEntries.Count >= 5);
Assert.IsTrue(debugInfo.StackEntries[0].Contains("ExceptionExtensionsTest.ThrowException"));
Assert.IsTrue(debugInfo.StackEntries[1].Contains("ExceptionExtensionsTest.ToRpcDebugInfo_WithInnerExceptionTest"));
Assert.IsTrue(debugInfo.StackEntries[2].Contains("InnerException:"));

var stackTraces = ConcatStackTraces(debugInfo);
Console.WriteLine("Test stack trace data:");
Console.WriteLine(stackTraces);
Assert.IsTrue(stackTraces.Contains("ExceptionExtensionsTest.ThrowException"));
Assert.IsTrue(stackTraces.Contains("ExceptionExtensionsTest.ToRpcDebugInfo_WithInnerExceptionTest"));
Assert.IsTrue(stackTraces.Contains("InnerException: System.ApplicationException: inner exception"));
Assert.IsTrue(stackTraces.Contains("ExceptionExtensionsTest.ThrowInnerException"));
}
}

Expand All @@ -77,4 +87,16 @@ private void ThrowInnerException(string message)
{
throw new System.ApplicationException(message);
}

private string ConcatStackTraces(DebugInfo debugInfo)
{
var sb = new StringBuilder();

foreach (var stackEntry in debugInfo.StackEntries)
{
sb.AppendLine(stackEntry);
}

return sb.ToString();
}
}