Commit 9de989b
committed
okhttp: Avoid DNS lookup in test
Our tests assume localhost is in /etc/hosts or uses some other form of
local-only resolution. But that wouldn't apply to "host". What was
happening is this was causing a DNS resolution, which would fail, and
the InetSocketAddress would be "unresolved". Thus, the equivalent and
faster code would be `InetSocketAddress.createUnresolved("host", 1234)`.
But there doesn't seem to be any reason to avoid localhost in this test,
so swap to the more typical solution instead.
This should avoid flakes like:
```
io.grpc.okhttp.OkHttpClientTransportTest > invalidAuthorityPropagates FAILED
org.junit.runners.model.TestTimedOutException: test timed out after 10 seconds
at [email protected]/java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
at [email protected]/java.net.InetAddress$PlatformNameService.lookupAllHostAddr(InetAddress.java:929)
at [email protected]/java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1529)
at [email protected]/java.net.InetAddress$NameServiceAddresses.get(InetAddress.java:848)
at [email protected]/java.net.InetAddress.getAllByName0(InetAddress.java:1519)
at [email protected]/java.net.InetAddress.getAllByName(InetAddress.java:1378)
at [email protected]/java.net.InetAddress.getAllByName(InetAddress.java:1306)
at [email protected]/java.net.InetAddress.getByName(InetAddress.java:1256)
at [email protected]/java.net.InetSocketAddress.<init>(InetSocketAddress.java:220)
at app//io.grpc.okhttp.OkHttpClientTransportTest.invalidAuthorityPropagates(OkHttpClientTransportTest.java:1687)
```1 parent f1f40b0 commit 9de989b
File tree
1 file changed
+1
-1
lines changed- okhttp/src/test/java/io/grpc/okhttp
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1685 | 1685 | | |
1686 | 1686 | | |
1687 | 1687 | | |
1688 | | - | |
| 1688 | + | |
1689 | 1689 | | |
1690 | 1690 | | |
1691 | 1691 | | |
| |||
0 commit comments