Skip to content

Commit 446a09d

Browse files
authored
[macOS] Use consistent filenames for tests (flutter#37755)
Previously there were two conventions for test filenames in the macOS embedder: some ended in Unittests.mm and others eneded in Test.mm. This applies a consistent naming convention, which is also consistent with the iOS and common Darwin tests. Stock C++ unittests should continue to use the _unittests.cc convention.
1 parent 8e4a718 commit 446a09d

File tree

8 files changed

+12
-12
lines changed

8 files changed

+12
-12
lines changed

ci/licenses_golden/licenses_flutter

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2619,16 +2619,16 @@ FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterBacki
26192619
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterBackingStore.mm
26202620
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterChannelKeyResponder.h
26212621
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterChannelKeyResponder.mm
2622-
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterChannelKeyResponderUnittests.mm
2622+
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterChannelKeyResponderTest.mm
26232623
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterCompositor.h
26242624
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterCompositor.mm
2625-
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterCompositorUnittests.mm
2625+
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterCompositorTest.mm
26262626
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterDartProject.mm
26272627
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterDartProject_Internal.h
2628-
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderExternalTextureUnittests.mm
2628+
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderExternalTextureTest.mm
26292629
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.h
26302630
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponder.mm
2631-
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponderUnittests.mm
2631+
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponderTest.mm
26322632
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterEngine.mm
26332633
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm
26342634
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTestUtils.h
@@ -2641,7 +2641,7 @@ FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterIOSur
26412641
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterKeyPrimaryResponder.h
26422642
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterKeyboardManager.h
26432643
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterKeyboardManager.mm
2644-
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterKeyboardManagerUnittests.mm
2644+
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterKeyboardManagerTest.mm
26452645
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterKeyboardViewDelegate.h
26462646
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterMenuPlugin.h
26472647
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterMenuPlugin.mm
@@ -2682,7 +2682,7 @@ FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterViewC
26822682
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterViewController_Internal.h
26832683
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterViewEngineProvider.h
26842684
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterViewEngineProvider.mm
2685-
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterViewEngineProviderUnittests.mm
2685+
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterViewEngineProviderTest.mm
26862686
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/FlutterViewProvider.h
26872687
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/KeyCodeMap.g.mm
26882688
FILE: ../../../flutter/shell/platform/darwin/macos/framework/Source/KeyCodeMap_Internal.h

shell/platform/darwin/macos/BUILD.gn

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -165,14 +165,14 @@ executable("flutter_desktop_darwin_unittests") {
165165

166166
sources = [
167167
"framework/Source/AccessibilityBridgeMacTest.mm",
168-
"framework/Source/FlutterChannelKeyResponderUnittests.mm",
169-
"framework/Source/FlutterCompositorUnittests.mm",
170-
"framework/Source/FlutterEmbedderExternalTextureUnittests.mm",
171-
"framework/Source/FlutterEmbedderKeyResponderUnittests.mm",
168+
"framework/Source/FlutterChannelKeyResponderTest.mm",
169+
"framework/Source/FlutterCompositorTest.mm",
170+
"framework/Source/FlutterEmbedderExternalTextureTest.mm",
171+
"framework/Source/FlutterEmbedderKeyResponderTest.mm",
172172
"framework/Source/FlutterEngineTest.mm",
173173
"framework/Source/FlutterEngineTestUtils.h",
174174
"framework/Source/FlutterEngineTestUtils.mm",
175-
"framework/Source/FlutterKeyboardManagerUnittests.mm",
175+
"framework/Source/FlutterKeyboardManagerTest.mm",
176176
"framework/Source/FlutterMenuPluginTest.mm",
177177
"framework/Source/FlutterPlatformNodeDelegateMacTest.mm",
178178
"framework/Source/FlutterPlatformViewControllerTest.mm",
@@ -183,7 +183,7 @@ executable("flutter_desktop_darwin_unittests") {
183183
"framework/Source/FlutterViewControllerTest.mm",
184184
"framework/Source/FlutterViewControllerTestUtils.h",
185185
"framework/Source/FlutterViewControllerTestUtils.mm",
186-
"framework/Source/FlutterViewEngineProviderUnitTests.mm",
186+
"framework/Source/FlutterViewEngineProviderTest.mm",
187187
"framework/Source/TestFlutterPlatformView.h",
188188
"framework/Source/TestFlutterPlatformView.mm",
189189
]

shell/platform/darwin/macos/framework/Source/FlutterChannelKeyResponderUnittests.mm renamed to shell/platform/darwin/macos/framework/Source/FlutterChannelKeyResponderTest.mm

File renamed without changes.

shell/platform/darwin/macos/framework/Source/FlutterCompositorUnittests.mm renamed to shell/platform/darwin/macos/framework/Source/FlutterCompositorTest.mm

File renamed without changes.

shell/platform/darwin/macos/framework/Source/FlutterEmbedderExternalTextureUnittests.mm renamed to shell/platform/darwin/macos/framework/Source/FlutterEmbedderExternalTextureTest.mm

File renamed without changes.

shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponderUnittests.mm renamed to shell/platform/darwin/macos/framework/Source/FlutterEmbedderKeyResponderTest.mm

File renamed without changes.

shell/platform/darwin/macos/framework/Source/FlutterKeyboardManagerUnittests.mm renamed to shell/platform/darwin/macos/framework/Source/FlutterKeyboardManagerTest.mm

File renamed without changes.

shell/platform/darwin/macos/framework/Source/FlutterViewEngineProviderUnittests.mm renamed to shell/platform/darwin/macos/framework/Source/FlutterViewEngineProviderTest.mm

File renamed without changes.

0 commit comments

Comments
 (0)