Skip to content

Commit ed2c24b

Browse files
authored
Add coveralls support to Travis (flutter#4690)
This patch causes us to upload a coverage report to coveralls.io.
1 parent 0f2c3dc commit ed2c24b

File tree

4 files changed

+14
-6
lines changed

4 files changed

+14
-6
lines changed

.travis.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,14 @@ addons:
66
- ubuntu-toolchain-r-test # if we don't specify this, the libstdc++6 we get is the wrong version
77
packages:
88
- libstdc++6
9+
install:
10+
- gem install coveralls-lcov
911
before_script:
1012
- ./dev/bots/setup.sh
1113
script:
1214
- ./dev/bots/test.sh
15+
after_success:
16+
- coveralls-lcov packages/flutter/coverage/lcov.info
1317
cache:
1418
directories:
1519
- $HOME/.pub-cache

dev/bots/test.sh

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,13 @@ flutter analyze --flutter-repo
2323
(cd dev/automated_tests; ! flutter test test_smoke_test/fail_test.dart > /dev/null)
2424
(cd dev/automated_tests; flutter test test_smoke_test/pass_test.dart > /dev/null)
2525

26+
COVERAGE_FLAG=
27+
if [ -n $TRAVIS ]; then
28+
COVERAGE_FLAG=--coverage
29+
fi
30+
2631
# run tests
27-
(cd packages/flutter; flutter test)
32+
(cd packages/flutter; flutter test $COVERAGE_FLAG)
2833
(cd packages/flutter_driver; dart -c test/all.dart)
2934
(cd packages/flutter_sprites; flutter test)
3035
(cd packages/flutter_test; flutter test)

packages/flutter_tools/lib/src/test/coverage_collector.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import 'dart:io';
88
import 'package:coverage/coverage.dart';
99
import 'package:path/path.dart' as path;
1010

11+
import '../dart/package_map.dart';
1112
import '../globals.dart';
1213

1314
class CoverageCollector {
@@ -61,9 +62,7 @@ class CoverageCollector {
6162
assert(enabled);
6263
await finishPendingJobs();
6364
printTrace('formating coverage data');
64-
// TODO(abarth): Use PackageMap.globalPackagesPath once
65-
// https://github.com/dart-lang/coverage/issues/100 is fixed.
66-
Resolver resolver = new Resolver(packageRoot: path.absolute('packages'));
65+
Resolver resolver = new Resolver(packagesPath: PackageMap.globalPackagesPath);
6766
Formatter formater = new LcovFormatter(resolver);
6867
List<String> reportOn = <String>[path.join(Directory.current.path, 'lib')];
6968
return await formater.format(_globalHitmap, reportOn: reportOn);

packages/flutter_tools/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@ environment:
1010
dependencies:
1111
archive: ^1.0.20
1212
args: ^0.13.4
13-
coverage: ^0.7.7
13+
coverage: ^0.7.8
1414
crypto: '>=1.1.1 <3.0.0'
1515
file: ^0.1.0
1616
http: ^0.11.3
1717
json_rpc_2: ^2.0.0
1818
json_schema: ^1.0.3
1919
linter: ^0.1.17
2020
mustache4dart: ^1.0.0
21-
package_config: ^0.1.3
21+
package_config: '>=0.1.5 <2.0.0'
2222
path: ^1.3.0
2323
pub_semver: ^1.0.0
2424
stack_trace: ^1.4.0

0 commit comments

Comments
 (0)