Skip to content

Commit 11271d1

Browse files
committed
Use file url for some tests to avoid network issue
1 parent 69cca49 commit 11271d1

File tree

5 files changed

+14
-3
lines changed

5 files changed

+14
-3
lines changed

Tests/SDWebImage Tests.xcodeproj/project.pbxproj

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,10 @@
2727
323B8E2020862322008952BE /* SDWebImageTestLoader.m in Sources */ = {isa = PBXBuildFile; fileRef = 323B8E1E20862322008952BE /* SDWebImageTestLoader.m */; };
2828
324047442271956F007C53E1 /* TestEXIF.png in Resources */ = {isa = PBXBuildFile; fileRef = 324047432271956F007C53E1 /* TestEXIF.png */; };
2929
324047452271956F007C53E1 /* TestEXIF.png in Resources */ = {isa = PBXBuildFile; fileRef = 324047432271956F007C53E1 /* TestEXIF.png */; };
30+
324371372C4F9E0900BEB4F5 /* TestICCProfile.jpg in Resources */ = {isa = PBXBuildFile; fileRef = 324371362C4F9E0900BEB4F5 /* TestICCProfile.jpg */; };
31+
324371382C4F9E0900BEB4F5 /* TestICCProfile.jpg in Resources */ = {isa = PBXBuildFile; fileRef = 324371362C4F9E0900BEB4F5 /* TestICCProfile.jpg */; };
32+
324371392C4F9E0900BEB4F5 /* TestICCProfile.jpg in Resources */ = {isa = PBXBuildFile; fileRef = 324371362C4F9E0900BEB4F5 /* TestICCProfile.jpg */; };
33+
3243713A2C4F9E0900BEB4F5 /* TestICCProfile.jpg in Resources */ = {isa = PBXBuildFile; fileRef = 324371362C4F9E0900BEB4F5 /* TestICCProfile.jpg */; };
3034
32464A902B7B1833006BE70E /* [email protected] in Resources */ = {isa = PBXBuildFile; fileRef = 32648066250232F7004FA0FC /* [email protected] */; };
3135
32464A912B7B1833006BE70E /* TestImage.nef in Resources */ = {isa = PBXBuildFile; fileRef = 32F788A2290D252200B57A1C /* TestImage.nef */; };
3236
32464A922B7B1833006BE70E /* TestImage.heic in Resources */ = {isa = PBXBuildFile; fileRef = 327A418B211D660600495442 /* TestImage.heic */; };
@@ -190,6 +194,7 @@
190194
323B8E1D20862322008952BE /* SDWebImageTestLoader.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = SDWebImageTestLoader.h; sourceTree = "<group>"; };
191195
323B8E1E20862322008952BE /* SDWebImageTestLoader.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = SDWebImageTestLoader.m; sourceTree = "<group>"; };
192196
324047432271956F007C53E1 /* TestEXIF.png */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = TestEXIF.png; sourceTree = "<group>"; };
197+
324371362C4F9E0900BEB4F5 /* TestICCProfile.jpg */ = {isa = PBXFileReference; lastKnownFileType = image.jpeg; path = TestICCProfile.jpg; sourceTree = "<group>"; };
193198
32464A892B7B0FF2006BE70E /* Tests Vision.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = "Tests Vision.xctest"; sourceTree = BUILT_PRODUCTS_DIR; };
194199
32515F9724AF1919005E8F79 /* TestImageStatic.webp */ = {isa = PBXFileReference; lastKnownFileType = file; path = TestImageStatic.webp; sourceTree = "<group>"; };
195200
32515F9824AF1919005E8F79 /* TestImageAnimated.webp */ = {isa = PBXFileReference; lastKnownFileType = file; path = TestImageAnimated.webp; sourceTree = "<group>"; };
@@ -340,6 +345,7 @@
340345
isa = PBXGroup;
341346
children = (
342347
32648066250232F7004FA0FC /* [email protected] */,
348+
324371362C4F9E0900BEB4F5 /* TestICCProfile.jpg */,
343349
3278F5E12B04C1AC0004A6EE /* IndexedPNG.png */,
344350
32C268272B888A4100CA29AE /* RGBA16PNG.png */,
345351
433BBBBA1D7EFA8B0086B6E9 /* MonochromeTestImage.jpg */,
@@ -597,6 +603,7 @@
597603
32464A992B7B1833006BE70E /* TestEXIF.png in Resources */,
598604
32464A922B7B1833006BE70E /* TestImage.heic in Resources */,
599605
32464A9D2B7B1833006BE70E /* TestImageAnimated.apng in Resources */,
606+
3243713A2C4F9E0900BEB4F5 /* TestICCProfile.jpg in Resources */,
600607
32464A9F2B7B1833006BE70E /* IndexedPNG.png in Resources */,
601608
32464AA02B7B1833006BE70E /* TestImage.jpg in Resources */,
602609
32464A932B7B1833006BE70E /* TestImageAnimated.heics in Resources */,
@@ -627,6 +634,7 @@
627634
329922872365DC6C00EAFD97 /* TestLoopCount.gif in Resources */,
628635
3299228C2365DC6C00EAFD97 /* TestImage.heif in Resources */,
629636
3234306423E2BAC800C290C8 /* TestImage.pdf in Resources */,
637+
324371392C4F9E0900BEB4F5 /* TestICCProfile.jpg in Resources */,
630638
320224F92440C39B00E5B29D /* TestImageLarge.png in Resources */,
631639
321F311027D0DC490042B274 /* TestImage.bmp in Resources */,
632640
329922892365DC6C00EAFD97 /* TestImageLarge.jpg in Resources */,
@@ -657,6 +665,7 @@
657665
324047452271956F007C53E1 /* TestEXIF.png in Resources */,
658666
32B99EA4203B31360017FD66 /* TestImage.jpg in Resources */,
659667
3234306323E2BAC800C290C8 /* TestImage.pdf in Resources */,
668+
324371382C4F9E0900BEB4F5 /* TestICCProfile.jpg in Resources */,
660669
320224F82440C39B00E5B29D /* TestImageLarge.png in Resources */,
661670
321F310F27D0DC490042B274 /* TestImage.bmp in Resources */,
662671
32B99EA6203B31360017FD66 /* TestImage.png in Resources */,
@@ -687,6 +696,7 @@
687696
32905E64211D786E00460FCF /* TestImage.heif in Resources */,
688697
43828A451DA67F9900000E62 /* TestImageLarge.jpg in Resources */,
689698
3234306223E2BAC800C290C8 /* TestImage.pdf in Resources */,
699+
324371372C4F9E0900BEB4F5 /* TestICCProfile.jpg in Resources */,
690700
320224F72440C39B00E5B29D /* TestImageLarge.png in Resources */,
691701
321F310E27D0DC490042B274 /* TestImage.bmp in Resources */,
692702
433BBBB71D7EF8200086B6E9 /* TestImage.gif in Resources */,
117 KB
Loading

Tests/Tests/SDAnimatedImageTest.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ - (void)test22AnimatedImageViewCategory {
325325
- (void)test23AnimatedImageViewCategoryProgressive {
326326
XCTestExpectation *expectation = [self expectationWithDescription:@"test SDAnimatedImageView view category progressive"];
327327
SDAnimatedImageView *imageView = [SDAnimatedImageView new];
328-
NSURL *testURL = [NSURL URLWithString:kTestGIFURL];
328+
NSURL *testURL = [NSURL URLWithString:@"https://raw.githubusercontent.com/onevcat/APNGKit/2.2.0/Tests/APNGKitTests/Resources/General/APNG-cube.apng"];
329329
[SDImageCache.sharedImageCache removeImageFromMemoryForKey:testURL.absoluteString];
330330
[SDImageCache.sharedImageCache removeImageFromDiskForKey:testURL.absoluteString];
331331
[imageView sd_setImageWithURL:testURL placeholderImage:nil options:SDWebImageProgressiveLoad progress:^(NSInteger receivedSize, NSInteger expectedSize, NSURL * _Nullable targetURL) {

Tests/Tests/SDTestCase.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
NSString *const kTestJPEGURL = @"https://placehold.co/50x50.jpg";
1515
NSString *const kTestProgressiveJPEGURL = @"https://raw.githubusercontent.com/ibireme/YYImage/master/Demo/YYImageDemo/mew_progressive.jpg";
1616
NSString *const kTestPNGURL = @"https://placehold.co/50x50.png";
17-
NSString *const kTestGIFURL = @"https://media.giphy.com/media/UEsrLdv7ugRTq/giphy.gif";
17+
NSString *const kTestGIFURL = @"https://upload.wikimedia.org/wikipedia/commons/2/2c/Rotating_earth_%28large%29.gif";
1818
NSString *const kTestAPNGPURL = @"https://upload.wikimedia.org/wikipedia/commons/1/14/Animated_PNG_example_bouncing_beach_ball.png";
1919

2020
@implementation SDTestCase

Tests/Tests/SDWebImageManagerTests.m

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -640,7 +640,8 @@ - (void)test21ThatQueryOriginalDiskCacheFromThumbnailShouldNotWriteBackDiskCache
640640

641641
- (void)test22ThatForceDecodePolicyAutomatic {
642642
XCTestExpectation *expectation = [self expectationWithDescription:@"Automatic policy with ICC profile colorspace image should force-decode"];
643-
NSURL *url = [NSURL URLWithString:@"http://photodb.illusdolphin.net/media/15292/browsertest.jpg"];
643+
NSString * testImagePath = [[NSBundle bundleForClass:[self class]] pathForResource:@"TestICCProfile" ofType:@"jpg"];
644+
NSURL *url = [NSURL fileURLWithPath:testImagePath];
644645
SDImageCoderHelper.defaultDecodeSolution = SDImageCoderDecodeSolutionCoreGraphics; // Temp set
645646
[SDWebImageManager.sharedManager loadImageWithURL:url options:SDWebImageFromLoaderOnly context:@{SDWebImageContextImageForceDecodePolicy : @(SDImageForceDecodePolicyAutomatic)} progress:nil completed:^(UIImage * _Nullable image, NSData * _Nullable data, NSError * _Nullable error, SDImageCacheType cacheType, BOOL finished, NSURL * _Nullable imageURL) {
646647
expect(image).notTo.beNil();

0 commit comments

Comments
 (0)