properly handle the case where struct pointers are nil

chbug · hoisie · commit d6d24d8fe4df · 2010-11-06T23:33:13.000+08:00
diff --git a/mustache.go b/mustache.go
@@ -417,6 +417,9 @@ func isNil(v reflect.Value) bool {
     }
 
     valueInd := indirect(v)
+    if valueInd == nil {
+        return true
+    }
     switch val := valueInd.(type) {
     case *reflect.BoolValue:
         return !val.Get()
diff --git a/mustache_test.go b/mustache_test.go
@@ -108,6 +108,7 @@ var tests = []Test{
     {`{{#users}}{{Name}}{{/users}}`, map[string]interface{}{"users": []User{{"Mike", 1}}}, "Mike"},
 
     {`{{#users}}gone{{Name}}{{/users}}`, map[string]interface{}{"users": nil}, ""},
+    {`{{#users}}gone{{Name}}{{/users}}`, map[string]interface{}{"users": (*User)(nil)}, ""},
     {`{{#users}}gone{{Name}}{{/users}}`, map[string]interface{}{"users": []User{}}, ""},
     {`{{#users}}{{Name}}{{/users}}`, map[string]interface{}{"users": []*User{&User{"Mike", 1}}}, "Mike"},
     {`{{#users}}{{Name}}{{/users}}`, map[string]interface{}{"users": vector.Vector([]interface{}{&User{"Mike", 12}})}, "Mike"},

Original file line number	Diff line number	Diff line change
`@@ -417,6 +417,9 @@ func isNil(v reflect.Value) bool {`
`417`	`417`	`}`
`418`	`418`
`419`	`419`	`valueInd := indirect(v)`
	`420`	`+ if valueInd == nil {`
	`421`	`+ return true`
	`422`	`+ }`
`420`	`423`	`switch val := valueInd.(type) {`
`421`	`424`	`case *reflect.BoolValue:`
`422`	`425`	`return !val.Get()`