Consistently use danger instead of error.

Author: sebastianbergmann

PHP/CodeCoverage/Report/HTML/Renderer.php

@@ -107,26 +107,6 @@ public function __construct($templatePath, $charset, $generator, $date, $lowUppe
         $this->highLowerBound = $highLowerBound;
     }
 
-    /**
-     * @param  integer $percent
-     * @return string
-     */
-    protected function getColorLevel($percent)
-    {
-        if ($percent < $this->lowUpperBound) {
-            return 'error';
-        }
-
-        else if ($percent >= $this->lowUpperBound &&
-                 $percent <  $this->highLowerBound) {
-            return 'warning';
-        }
-
-        else {
-            return 'success';
-        }
-    }
-
     /**
      * @param  Text_Template $template
      * @param  array         $data
@@ -246,26 +226,35 @@ protected function setCommonTemplateVariables(Text_Template $template, PHP_CodeC
     }
 
     protected function getCoverageBar($percent)
+    {
+        $level = $this->getColorLevel($percent);
+
+        $template = new Text_Template(
+          $this->templatePath . 'coverage_bar.html'
+        );
+
+        $template->setVar(array('level' => $level, 'percent' => $percent));
+
+        return $template->render();
+    }
+
+    /**
+     * @param  integer $percent
+     * @return string
+     */
+    protected function getColorLevel($percent)
     {
         if ($percent < $this->lowUpperBound) {
-            $level = 'danger';
+            return 'danger';
         }
 
         else if ($percent >= $this->lowUpperBound &&
                  $percent <  $this->highLowerBound) {
-            $level = 'warning';
+            return 'warning';
         }
 
         else {
-            $level = 'success';
+            return 'success';
         }
-
-        $template = new Text_Template(
-          $this->templatePath . 'coverage_bar.html'
-        );
-
-        $template->setVar(array('level' => $level, 'percent' => $percent));
-
-        return $template->render();
     }
 }

PHP/CodeCoverage/Report/HTML/Renderer/File.php

@@ -340,7 +340,7 @@ protected function renderSource(PHP_CodeCoverage_Report_Node_File $node)
                 }
 
                 else if ($numTests == 0) {
-                    $trClass = ' class="error"';
+                    $trClass = ' class="danger"';
                 }
 
                 else {
@@ -367,12 +367,12 @@ protected function renderSource(PHP_CodeCoverage_Report_Node_File $node)
                             break;
 
                             case 3: {
-                                $testCSS = ' class="error"';
+                                $testCSS = ' class="danger"';
                             }
                             break;
 
                             case 4: {
-                                $testCSS = ' class="error"';
+                                $testCSS = ' class="danger"';
                             }
                             break;
 

PHP/CodeCoverage/Report/HTML/Renderer/Template/css/style.css

@@ -18,7 +18,7 @@ body {
  background-color: #dff0d8;
 }
 
-.table tbody td.error, li.error, span.error {
+.table tbody tr.danger, .table tbody td.danger, li.danger, span.danger {
  background-color: #f2dede;
 }
 
@@ -63,7 +63,7 @@ pre span.string {
  color: #2e3436;
 }
 
-span.success, span.warning, span.error {
+span.success, span.warning, span.danger {
  margin-right: 2px;
  padding-left: 10px;
  padding-right: 10px;

PHP/CodeCoverage/Report/HTML/Renderer/Template/directory.html.dist

@@ -44,7 +44,7 @@
    <footer>
     <h4>Legend</h4>
     <p>
-     <span class="error"><strong>Low</strong>: 0% to {low_upper_bound}%</span>
+     <span class="danger"><strong>Low</strong>: 0% to {low_upper_bound}%</span>
      <span class="warning"><strong>Medium</strong>: {low_upper_bound}% to {high_lower_bound}%</span>
      <span class="success"><strong>High</strong>: {high_lower_bound}% to 100%</span>
     </p>

PHP/CodeCoverage/Report/HTML/Renderer/Template/file.html.dist

@@ -50,7 +50,7 @@
     <h4>Legend</h4>
     <p>
      <span class="success"><strong>Executed</strong></span>
-     <span class="error"><strong>Not Executed</strong></span>
+     <span class="danger"><strong>Not Executed</strong></span>
      <span class="warning"><strong>Dead Code</strong></span>
     </p>
     <p>