Skip to content

Draft: Rename collective calls #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Draft: Rename collective calls #290

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
875a174
rename collective calls prefix with _coll
TheAssembler1 Sep 16, 2025
487e7cf
function rename
TheAssembler1 Sep 16, 2025
0076c65
Committing clang-format changes
github-actions[bot] Sep 16, 2025
f406528
formatting
TheAssembler1 Sep 16, 2025
2401eb8
Add MPI communicator to collective calls.
TheAssembler1 Oct 21, 2025
4b40479
Committing clang-format changes
github-actions[bot] Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Committing clang-format changes
  • Loading branch information
@github-actions
github-actions[bot] committed Oct 21, 2025
commit 4b404795c04e592ad250d9183f4bcfcfa0a3db1f
20 changes: 10 additions & 10 deletions examples/bdcats.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ main(int argc, char **argv)
pdcid_t region_xx, region_yy, region_zz, region_pxx, region_pyy, region_pzz, region_id11, region_id22;
perr_t ret;

float *x, *y, *z;
float *px, *py, *pz;
int *id1, *id2;
float * x, *y, *z;
float * px, *py, *pz;
int * id1, *id2;
uint64_t numparticles;
int ndim = 1;
uint64_t *offset;
Expand Down Expand Up @@ -101,11 +101,11 @@ main(int argc, char **argv)
if (cont_id == 0)
LOG_ERROR("Failed to create container");

// open objects
// open objects
#ifdef ENABLE_MPI
obj_xx = PDCobj_open_coll("obj-var-xx", pdc_id, MPI_COMM_WORLD);
#else
obj_xx = PDCobj_open("obj-var-xx", pdc_id);
obj_xx = PDCobj_open("obj-var-xx", pdc_id);
#endif
if (obj_xx == 0) {
LOG_ERROR("Error when open object %s\n", "obj-var-xx");
Expand All @@ -114,7 +114,7 @@ main(int argc, char **argv)
#ifdef ENABLE_MPI
obj_yy = PDCobj_open_coll("obj-var-yy", pdc_id, MPI_COMM_WORLD);
#else
obj_yy = PDCobj_open("obj-var-xx", pdc_id);
obj_yy = PDCobj_open("obj-var-xx", pdc_id);
#endif
if (obj_yy == 0) {
LOG_ERROR("Error when open object %s\n", "obj-var-yy");
Expand All @@ -123,7 +123,7 @@ main(int argc, char **argv)
#ifdef ENABLE_MPI
obj_zz = PDCobj_open_coll("obj-var-zz", pdc_id, MPI_COMM_WORLD);
#else
obj_zz = PDCobj_open("obj-var-xx", pdc_id);
obj_zz = PDCobj_open("obj-var-xx", pdc_id);
#endif
if (obj_zz == 0) {
LOG_ERROR("Error when open object %s\n", "obj-var-zz");
Expand All @@ -132,7 +132,7 @@ main(int argc, char **argv)
#ifdef ENABLE_MPI
obj_pxx = PDCobj_open_coll("obj-var-pxx", pdc_id, MPI_COMM_WORLD);
#else
obj_pxx = PDCobj_open("obj-var-xx", pdc_id);
obj_pxx = PDCobj_open("obj-var-xx", pdc_id);
#endif
if (obj_pxx == 0) {
LOG_ERROR("Error when open object %s\n", "obj-var-pxx");
Expand All @@ -141,7 +141,7 @@ main(int argc, char **argv)
#ifdef ENABLE_MPI
obj_pyy = PDCobj_open_coll("obj-var-pyy", pdc_id, MPI_COMM_WORLD);
#else
obj_pyy = PDCobj_open("obj-var-xx", pdc_id);
obj_pyy = PDCobj_open("obj-var-xx", pdc_id);
#endif
if (obj_pyy == 0) {
LOG_ERROR("Error when open object %s\n", "obj-var-pyy");
Expand All @@ -150,7 +150,7 @@ main(int argc, char **argv)
#ifdef ENABLE_MPI
obj_pzz = PDCobj_open_coll("obj-var-pzz", pdc_id, MPI_COMM_WORLD);
#else
obj_pzz = PDCobj_open("obj-var-xx", pdc_id);
obj_pzz = PDCobj_open("obj-var-xx", pdc_id);
#endif
if (obj_pzz == 0) {
LOG_ERROR("Error when open object %s\n", "obj-var-pzz");
Expand Down
14 changes: 7 additions & 7 deletions examples/bdcats_batch.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ main(int argc, char **argv)
char obj_name[128];
float *x, *y, *z;
float *px, *py, *pz;
int *id1, *id2;
int * id1, *id2;
// int x_dim = 64;
// int y_dim = 64;
// int z_dim = 64;
Expand Down Expand Up @@ -177,7 +177,7 @@ main(int argc, char **argv)
#ifdef ENABLE_MPI
obj_xx[i] = PDCobj_open_coll(obj_name, pdc_id, comm);
#else
obj_xx[i] = PDCobj_open(obj_name, pdc_id);
obj_xx[i] = PDCobj_open(obj_name, pdc_id);
#endif
if (obj_xx[i] == 0) {
LOG_ERROR("Error getting an object id of %s from server, exit...\n", "obj-var-xx");
Expand All @@ -187,7 +187,7 @@ main(int argc, char **argv)
#ifdef ENABLE_MPI
obj_yy[i] = PDCobj_open_coll(obj_name, pdc_id, comm);
#else
obj_yy[i] = PDCobj_open(obj_name, pdc_id);
obj_yy[i] = PDCobj_open(obj_name, pdc_id);
#endif
if (obj_yy[i] == 0) {
LOG_ERROR("Error getting an object id of %s from server, exit...\n", "obj-var-yy");
Expand All @@ -197,7 +197,7 @@ main(int argc, char **argv)
#ifdef ENABLE_MPI
obj_zz[i] = PDCobj_open_coll(obj_name, pdc_id, comm);
#else
obj_zz[i] = PDCobj_open(obj_name, pdc_id);
obj_zz[i] = PDCobj_open(obj_name, pdc_id);
#endif
if (obj_zz[i] == 0) {
LOG_ERROR("Error getting an object id of %s from server, exit...\n", "obj-var-zz");
Expand All @@ -207,7 +207,7 @@ main(int argc, char **argv)
#ifdef ENABLE_MPI
obj_pxx[i] = PDCobj_open_coll(obj_name, pdc_id, comm);
#else
obj_pxx[i] = PDCobj_open(obj_name, pdc_id);
obj_pxx[i] = PDCobj_open(obj_name, pdc_id);
#endif
if (obj_pxx[i] == 0) {
LOG_ERROR("Error getting an object id of %s from server, exit...\n", "obj-var-pxx");
Expand All @@ -217,7 +217,7 @@ main(int argc, char **argv)
#ifdef ENABLE_MPI
obj_pyy[i] = PDCobj_open_coll(obj_name, pdc_id, comm);
#else
obj_pyy[i] = PDCobj_open(obj_name, pdc_id);
obj_pyy[i] = PDCobj_open(obj_name, pdc_id);
#endif
if (obj_pyy[i] == 0) {
LOG_ERROR("Error getting an object id of %s from server, exit...\n", "obj-var-pyy");
Expand All @@ -227,7 +227,7 @@ main(int argc, char **argv)
#ifdef ENABLE_MPI
obj_pzz[i] = PDCobj_open_coll(obj_name, pdc_id, comm);
#else
obj_pzz[i] = PDCobj_open(obj_name, pdc_id);
obj_pzz[i] = PDCobj_open(obj_name, pdc_id);
#endif
if (obj_pzz[i] == 0) {
LOG_ERROR("Error getting an object id of %s from server, exit...\n", "obj-var-pzz");
Expand Down
4 changes: 2 additions & 2 deletions examples/haccio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ mask | int16 | 2 bytes
* ------------------
*/

static char *VAR_NAMES[NUM_VARS] = {"xx", "yy", "zz", "vx", "vy", "vz", "phi", "phd", "mask"};
static char * VAR_NAMES[NUM_VARS] = {"xx", "yy", "zz", "vx", "vy", "vz", "phi", "phd", "mask"};
static pdc_var_type_t VAR_TYPES[NUM_VARS] = {PDC_FLOAT, PDC_FLOAT, PDC_FLOAT, PDC_FLOAT, PDC_FLOAT,
PDC_FLOAT, PDC_FLOAT, PDC_INT64, PDC_INT16};
static int NUM_PARTICLES = (1 * 1024 * 1024);
void *buffers[NUM_VARS];
void * buffers[NUM_VARS];

MPI_Comm comm;

Expand Down
4 changes: 2 additions & 2 deletions examples/haccio_v2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ mask | int16 | 2 bytes
* ------------------
*/

static char *VAR_NAMES[NUM_VARS] = {"xx", "yy", "zz", "vx", "vy", "vz", "phi", "phd", "mask"};
static char * VAR_NAMES[NUM_VARS] = {"xx", "yy", "zz", "vx", "vy", "vz", "phi", "phd", "mask"};
static pdc_var_type_t VAR_TYPES[NUM_VARS] = {PDC_FLOAT, PDC_FLOAT, PDC_FLOAT, PDC_FLOAT, PDC_FLOAT,
PDC_FLOAT, PDC_FLOAT, PDC_INT64, PDC_INT16};
static int NUM_PARTICLES = (1 * 1024 * 1024);
void *buffers[NUM_VARS];
void * buffers[NUM_VARS];

MPI_Comm comm;

Expand Down
2 changes: 1 addition & 1 deletion examples/tileio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ main(int argc, char **argv)
pdcid_t obj_id, obj_prop;
pdcid_t local_region_id, global_region_id;

double *local_buffer = (double *)malloc(g_x_ept * g_y_ept * sizeof(double));
double * local_buffer = (double *)malloc(g_x_ept * g_y_ept * sizeof(double));
uint64_t dims[NUM_DIMS] = {g_x_ept, g_y_ept};
uint64_t local_offsets[NUM_DIMS], global_offsets[NUM_DIMS];
local_offsets[0] = 0;
Expand Down
6 changes: 3 additions & 3 deletions examples/vpicio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ main(int argc, char **argv)
#else
int comm = 1;
#endif
float *x, *y, *z;
float *px, *py, *pz;
int *id1, *id2;
float * x, *y, *z;
float * px, *py, *pz;
int * id1, *id2;
int x_dim = 64;
int y_dim = 64;
int z_dim = 64;
Expand Down
8 changes: 4 additions & 4 deletions examples/vpicio_batch.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ main(int argc, char **argv)
int comm = 1;
#endif
char obj_name[128];
float *x, *y, *z;
float *px, *py, *pz;
int *id1, *id2;
float * x, *y, *z;
float * px, *py, *pz;
int * id1, *id2;
int x_dim = 64;
int y_dim = 64;
int z_dim = 64;
Expand All @@ -82,7 +82,7 @@ main(int argc, char **argv)
unsigned sleep_time = 0;
int test_method = 2;
int do_flush = 0;
pdcid_t *transfer_request_x, *transfer_request_y, *transfer_request_z, *transfer_request_px,
pdcid_t * transfer_request_x, *transfer_request_y, *transfer_request_z, *transfer_request_px,
*transfer_request_py, *transfer_request_pz, *transfer_request_id1, *transfer_request_id2, *ptr,
*temp_requests;

Expand Down
6 changes: 3 additions & 3 deletions examples/vpicio_old.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ main(int argc, char **argv)
#else
int comm = 1;
#endif
float *x, *y, *z;
float *px, *py, *pz;
int *id1, *id2;
float * x, *y, *z;
float * px, *py, *pz;
int * id1, *id2;
int x_dim = 64;
int y_dim = 64;
int z_dim = 64;
Expand Down
22 changes: 11 additions & 11 deletions src/api/include/pdc_client_connect.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,23 +60,23 @@ struct _pdc_client_lookup_args {
uint32_t client_id;
int ret;
int is_init;
char *ret_string;
char *client_addr;
char * ret_string;
char * client_addr;

uint32_t user_id;
const char *app_name;
const char * app_name;
int time_step;
uint32_t hash_value;
const char *tags;
const char * tags;
hg_request_t *request;
};

struct _pdc_client_transform_args {
size_t size;
void *data;
void *transform_result;
void * data;
void * transform_result;
struct _pdc_region_transform_ftn_info *this_transform;
struct pdc_region_info *region_info;
struct pdc_region_info * region_info;
int type_extent;
int transform_state;
int ret;
Expand Down Expand Up @@ -148,8 +148,8 @@ struct _pdc_query_result_list {
int query_id;
uint64_t nhits;
uint64_t *coords;
void *data;
void **data_arr;
void * data;
void ** data_arr;
uint64_t *data_arr_size;
uint64_t recv_data_nhits;

Expand Down Expand Up @@ -187,8 +187,8 @@ struct client_genetic_lookup_args {
struct _dart_perform_one_thread_param {
int server_id;
dart_perform_one_server_in_t *dart_in;
uint64_t **dart_out;
size_t *dart_out_size;
uint64_t ** dart_out;
size_t * dart_out_size;
};

#define PDC_CLIENT_DATA_SERVER() ((pdc_client_mpi_rank_g / pdc_nclient_per_server_g) % pdc_server_num_g)
Expand Down
Loading