feat: bump versions #330
Merged
feat: bump versions #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gordon Smith <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Purpose: Bump Graphviz, emsdk, and various dependency versions across the monorepo and synchronize associated test and documentation references.
- Update Graphviz from 14.0.1 to 14.0.2 (vcpkg overlay, test expectation, README).
- Update emsdk version from 4.0.15 to 4.0.17 (script and README).
- Increment multiple devDependency versions across packages.
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vcpkg-overlays/graphviz/vcpkg.json | Bumps Graphviz semver to 14.0.2 for vcpkg overlay. |
| vcpkg-overlays/graphviz/portfile.cmake | Updates source SHA512 to match new Graphviz version. |
| tests/bundlers/package.json | Updates bundler-related dependency versions. |
| scripts/cpp-install-emsdk.sh | Bumps emsdk install version to 4.0.17. |
| packages/zstd/package.json | Updates esbuild plugin devDependency version. |
| packages/wasm/package.json | Updates esbuild plugin devDependency version. |
| packages/llama/package.json | Updates esbuild plugin devDependency version. |
| packages/graphviz/tests/graphviz.spec.ts | Adjusts test to expect new Graphviz version. |
| packages/graphviz/package.json | Updates esbuild plugin devDependency version. |
| packages/expat/package.json | Updates esbuild plugin devDependency version. |
| packages/duckdb/package.json | Updates esbuild plugin devDependency version. |
| packages/base91/package.json | Updates esbuild plugin devDependency version. |
| package.json | Bumps multiple root-level devDependencies. |
| README.md | Synchronizes displayed Graphviz and emsdk versions with bumps. |
| let v = graphviz.version(); | ||
| expect(v).to.be.a.string; | ||
| expect(v).to.equal("14.0.1"); // Update README.md with the new version!!! | ||
| expect(v).to.equal("14.0.2"); // Update README.md with the new version!!! |
There was a problem hiding this comment.
[nitpick] Hard-coding the exact version string makes this test require edits for every patch release. Consider deriving the expected value from a single source of truth (e.g., reading package.json's version or asserting a prefix like v.startsWith("14.0.")) to reduce churn.
Suggested change
| expect(v).to.equal("14.0.2"); // Update README.md with the new version!!! | |
| expect(v.startsWith("14.0.")).to.be.true; // Accept any patch version for 14.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.