Detect and enable LSX/LASX on LoongArch based on compiler predefined macros.#20599
Merged
hrydgard merged 1 commit intohrydgard:masterfrom Jul 6, 2025
Merged
Detect and enable LSX/LASX on LoongArch based on compiler predefined macros.#20599hrydgard merged 1 commit intohrydgard:masterfrom
hrydgard merged 1 commit intohrydgard:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When attempting to compile for a LoongArch64 CPU without 128-bit vector instructions (LSX), I found that simply removing
add_compile_options(-mlsx)inCMakeLists.txtwas insufficient, asPPSSPP_ARCH_LOONGARCH64_LSXwas still being defined by default.This change now properly detects and enables LSX/LASX support on LoongArch64 based on compiler predefined macros.