mimicked elasticsearch's create index's indexname validation on the client side to throw hard validation error

Author: Mpdreamz

src/Nest/ConvenienceExtensions/CreateIndexExtensions.cs

@@ -56,7 +56,6 @@ private static TResponse CreateIndex<TResponse>(IElasticClient client, string in
 	        Func<Func<CreateIndexDescriptor, CreateIndexDescriptor>, TResponse> createIndexMethod)
 	    {
             index.ThrowIfNullOrEmpty("index");
-	        index.ThrownIfNotLowercase("index");
             createIndexSelector = createIndexSelector ?? (c => c);
             return createIndexMethod(c => createIndexSelector(c).Index(index));
         }

src/Nest/DSL/CreateIndexDescriptor.cs

@@ -1,6 +1,8 @@
 using System;
 using System.Collections.Generic;
+using System.IO;
 using System.Linq;
+using System.Text;
 using Elasticsearch.Net;
 using Newtonsoft.Json;
 
@@ -15,23 +17,47 @@ public interface ICreateIndexRequest : IIndexPath<CreateIndexRequestParameters>
 
 	internal static class CreateIndexPathInfo
 	{
+		private static char[] _invalidChars = new[] { '\\', '/', '*', '?', '"', '<', '>', '|', ' ', ',', '#' };
+		private static string _invalidCharsMessage = string.Join(", ", _invalidChars);
+
 		public static void Update(ElasticsearchPathInfo<CreateIndexRequestParameters> pathInfo, ICreateIndexRequest request)
 		{
 			pathInfo.HttpMethod = PathInfoHttpMethod.POST;
 		}
+
+		public static void Validate(ElasticsearchPathInfo<CreateIndexRequestParameters> pathInfo, ICreateIndexRequest request)
+		{
+			var index = pathInfo.Index;
+			if (index.StartsWith("_"))
+				throw new DslException("indexname {0} may not start with an underscore".F(index));
+
+			if (Encoding.UTF8.GetByteCount(index) > 255)
+				throw new DslException("indexname {0} exceeds maximum index name length of 255".F(index));
+
+			if (index.Any(char.IsUpper))
+				throw new DslException("indexname {0} contains uppercase characters".F(index));
+
+			if (index.Any(c => _invalidChars.Contains(c)))
+				throw new DslException("indexname {0} contains one of {1} invalid characters".F(index, _invalidCharsMessage));
+
+		}
 	}
-	
+
 	public partial class CreateIndexRequest : IndexPathBase<CreateIndexRequestParameters>, ICreateIndexRequest
 	{
 		public CreateIndexRequest(IndexNameMarker index) : base(index) { }
 
 		public IndexSettings IndexSettings { get; set; }
-		
+
 		protected override void UpdatePathInfo(IConnectionSettingsValues settings, ElasticsearchPathInfo<CreateIndexRequestParameters> pathInfo)
 		{
 			CreateIndexPathInfo.Update(pathInfo, this);
 		}
 
+		protected override void ValidatePathInfo(ElasticsearchPathInfo<CreateIndexRequestParameters> pathInfo)
+		{
+			CreateIndexPathInfo.Validate(pathInfo, this);
+		}
 	}
 
 	[DescriptorFor("IndicesCreate")]
@@ -131,7 +157,7 @@ public CreateIndexDescriptor AddAlias(string aliasName, Func<CreateAliasDescript
 
 			return this;
 		}
-			
+
 
 		private CreateIndexDescriptor RemoveMapping(TypeNameMarker marker)
 		{
@@ -185,7 +211,7 @@ public CreateIndexDescriptor AddMapping<T>(RootObjectMapping rootObjectMapping,
 			}
 			else
 			{
-				typeMapping.Name = typeof (T);
+				typeMapping.Name = typeof(T);
 			}
 
 			this._indexSettings.Mappings.Add(typeMapping);
@@ -220,7 +246,7 @@ public CreateIndexDescriptor Analysis(Func<AnalysisDescriptor, AnalysisDescripto
 			this._indexSettings.Analysis = analysis == null ? null : analysis._AnalysisSettings;
 			return this;
 		}
-		
+
 		public CreateIndexDescriptor Similarity(Func<SimilarityDescriptor, SimilarityDescriptor> similaritySelector)
 		{
 			similaritySelector.ThrowIfNull("similaritySelector");
@@ -234,5 +260,10 @@ protected override void UpdatePathInfo(IConnectionSettingsValues settings, Elast
 			CreateIndexPathInfo.Update(pathInfo, this);
 		}
 
+		protected override void ValidatePathInfo(ElasticsearchPathInfo<CreateIndexRequestParameters> pathInfo)
+		{
+			CreateIndexPathInfo.Validate(pathInfo, this);
+		}
+
 	}
 }

src/Tests/Nest.Tests.Unit/Internals/Inferno/IndexNameResolverTests.cs

@@ -0,0 +1,60 @@
+using System;
+using System.Linq;
+using FluentAssertions;
+using NUnit.Framework;
+using Nest.Tests.MockData.Domain;
+
+namespace Nest.Tests.Unit.Internals.Inferno
+{
+	[TestFixture]
+	public class IndexNameResolverTests : BaseJsonTests
+	{
+		[Test]
+		public void Uppercase_Characters_AreNotAllowed()
+		{
+			var e = Assert.Throws<DslException>(() => this._client.CreateIndex(c => c
+				.Index("Hello")
+			));
+			e.Message.Should().Contain("contains uppercase characters");
+		}
+
+		[Test]
+		public void SanityCheckCharacters()
+		{
+			var e = Assert.Throws<DslException>(() => this._client.CreateIndex(c => c
+				.Index("rel>lo")
+			));
+			e.Message.Should().Contain("contains one of");
+		}
+
+		[Test]
+		public void IndexNameMayNotStartWithUnderscore()
+		{
+			var e = Assert.Throws<DslException>(() => this._client.CreateIndex(c => c
+				.Index("_hello")
+			));
+			e.Message.Should().Contain("may not start with an underscore");
+		}
+
+		[Test]
+		public void MaxLengthCheck()
+		{
+			var indexName = new String('a', 300);
+
+			var e = Assert.Throws<DslException>(() => this._client.CreateIndex(c => c
+				.Index(indexName)
+			));
+			e.Message.Should().Contain(indexName);
+			e.Message.Should().Contain("exceeds maximum");
+		}
+
+		[Test]
+		public void ValidIndexNameShouldNotThrow()
+		{
+			Assert.DoesNotThrow(() => this._client.CreateIndex(c => c
+				.Index("index_name")
+			));
+		}
+
+	}
+}

src/Tests/Nest.Tests.Unit/Nest.Tests.Unit.csproj

@@ -236,6 +236,7 @@
     <Compile Include="Internals\Inferno\EscapedFormatTests.cs" />
     <Compile Include="Internals\Inferno\HostNameWithPathTests.cs" />
     <Compile Include="Internals\Inferno\MapTypeNamesTests.cs" />
+    <Compile Include="Internals\Inferno\IndexNameResolverTests.cs" />
     <Compile Include="Internals\Serialize\ConnectionSettingsTests.cs" />
     <Compile Include="Internals\Serialize\NullValueHandlingTests.cs" />
     <Compile Include="Internals\Serialize\OptOutTests.cs" />