Skip to content

Conversation

@rob-simmons-human-element
  • adds Satis build config
  • adds a bit of JS that makes it scroll to the error when you are submitting an admin form, e.g. product or category forms
  • no one requested this functionality, I've just always thought it would be a useful enhancement to Magento admin forms, so you don't just sit there thinking the Save button is unresponsive.

I did some research and ensured that the function I'm overriding for this is identical at least back to Magento 2.4.2-p2, so it should be safe to use.

Though I'm committing the satis auto-build code, I am not committing directly to master, and will thus not be creating the tags (which I believe will trigger the actual auto-satis-build process).

…rror when you are submitting an admin form, e.g. product or category forms.
@Luwdo
Copy link
Contributor

Luwdo commented Jan 10, 2024

This is a public repo so it doesn't need a private satis build action. It is published to packagist.

The JS change is good i just would like a feature toggle and have it default off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants