use Counterparty.from_json_api (unit-finance#144)

Author: axshani

unit/models/payment.py

@@ -29,7 +29,7 @@ def __init__(self, id: str, created_at: datetime, status: PaymentStatus, counter
     def from_json_api(_id, _type, attributes, relationships):
         settlement_date = date_utils.to_date(attributes.get("settlementDate")) if attributes.get("settlementDate") else None
         return AchPaymentDTO(_id, date_utils.to_datetime(attributes["createdAt"]), attributes["status"],
-                             attributes["counterparty"], attributes["direction"], attributes["description"],
+                             Counterparty.from_json_api(attributes["counterparty"]), attributes["direction"], attributes["description"],
                              attributes["amount"], attributes.get("addenda"), attributes.get("reason"), settlement_date,
                              attributes.get("tags"), relationships)
 
@@ -177,7 +177,7 @@ def __init__(self, amount: int, description: str, plaid_processor_token: str, re
                  counterparty_name: Optional[str], verify_counterparty_balance: Optional[bool],
                  idempotency_key: Optional[str], tags: Optional[Dict[str, str]], direction: str = "Credit"):
         CreatePaymentBaseRequest.__init__(self, amount, description, relationships, idempotency_key, tags)
-        self.plaid_Processor_token = plaid_Processor_token
+        self.plaid_Processor_token = plaid_processor_token
         self.counterparty_name = counterparty_name
         self.verify_counterparty_balance = verify_counterparty_balance
 
@@ -186,10 +186,10 @@ def to_json_api(self) -> Dict:
         payload["data"]["attributes"]["counterparty"] = self.counterparty
         payload["data"]["attributes"]["plaidProcessorToken"] = self.plaid_processor_token
 
-        if counterparty_name:
+        if self.counterparty_name:
             payload["data"]["attributes"]["counterpartyName"] = self.counterparty_name
 
-        if verify_counterparty_balance:
+        if self.verify_counterparty_balance:
             payload["data"]["attributes"]["verifyCounterpartyBalance"] = self.verify_counterparty_balance
 
         return payload