[FAB-15882] Typescript corrections

- If a type is missing from a transaciton function fail fast
- Add in the missing serializer type definitions

Change-Id: I6ca70989a5eddfe999693b7b5300e6cd3951ceaa
Signed-off-by: Matthew B. White <whitemat@uk.ibm.com>

Author: mbwhite

fabric-contract-api/lib/annotations/transaction.js

@@ -10,7 +10,7 @@ const Logger = require('../logger');
 const logger = Logger.getLogger('./lib/annotations/transaction.js');
 require('reflect-metadata');
 
-module.exports.Transaction = function Transaction(commit = true) {
+module.exports.Transaction = function Transaction (commit = true) {
     return (target, propertyKey) => {
         logger.info('@Transaction args:', `Property Key -> ${propertyKey}, Commit -> ${commit},`, 'Target ->', target.constructor.name);
 
@@ -45,7 +45,9 @@ module.exports.Transaction = function Transaction(commit = true) {
             };
 
             const type = typeof paramType === 'function' ? paramType.name : paramType.toString();
-
+            if (type === 'Object') {
+                throw new Error(`Type not properly specified for parameter ${paramName}, can not process pure Object types`);
+            }
             obj.schema = utils.generateSchema(type);
 
             return obj;
@@ -76,7 +78,7 @@ module.exports.Transaction = function Transaction(commit = true) {
     };
 };
 
-module.exports.Returns = function Returns(returnType) {
+module.exports.Returns = function Returns (returnType) {
     return (target, propertyKey) => {
         logger.info('@Returns args:', `, Property Key -> ${propertyKey}, Return Type -> ${returnType},`, 'Target ->', target.constructor.name);
 
@@ -93,7 +95,7 @@ module.exports.Returns = function Returns(returnType) {
     };
 };
 
-module.exports.Param = function Param(paramName, paramType, description) {
+module.exports.Param = function Param (paramName, paramType, description) {
     return (target, propertyKey) => {
         logger.info('@Param args:', `Property Key -> ${propertyKey}, Param Name -> ${paramName}, Param Type -> ${paramType}, Description -> ${description},`, 'Target ->', target.constructor.name);
 

fabric-contract-api/test/unit/annotations/transaction.js

@@ -118,7 +118,25 @@ describe('Transaction.js', () => {
                 ]
             }], mockTarget);
         });
+        it ('should error if missing type', () => {
 
+            sandbox.stub(Reflect, 'getMetadata').onFirstCall().returns([{
+                name: 'someTransaction',
+                tag: ['submitTx']
+            }]).onSecondCall().returns([
+                MockContext,
+                'Object'
+            ]);
+
+            TransactionAnnotations.__set__('getParams', () => {
+                return ['ctx', 'param1'];
+            });
+
+            (() => {
+                transaction(mockTarget, 'mockKey');
+            }).should.throw(/Type not properly specified for parameter .*?, can not process pure Object types/);
+
+        });
         it ('should handle existing transactions of which matches name and already has param metadata', () => {
             const transactions = [{
                 name: 'mockKey',

fabric-contract-api/types/index.d.ts

@@ -33,6 +33,12 @@ declare module 'fabric-contract-api' {
 
     }
 
+
+    export class JSONSerializer {
+        toBuffer(result: any,schema:any,loggerPrefix?:string): Buffer;
+        fromBuffer(data: Buffer,schema:any,loggerPrefix?:string): any;
+    }
+
     export function Transaction(commit?: boolean): (target: any, propertyKey: string | symbol) => void;
     export function Param(paramName: string, paramType: string, description?: string): (target: any, propertyKey: string | symbol) => void;
     export function Returns(returnType?: string): (target: any, propertyKey: string | symbol) => void;