JsLint

Author: jettcalleja

src/others/minkowski-distance.js

@@ -6,10 +6,10 @@
     function chebyshevDistance (x, y, lx, p, mathfn) {
       var ret = -p;
       var i;
-      
-      for (i = 0; i < lx; i++) {
+
+      for (i = 0; i < lx; i += 1) {
         ret = mathfn(ret, Math.abs(x[i] - y[i]));
-      } 
+      }
 
       return ret;
     }
@@ -28,32 +28,28 @@
 
       if (p === Number.POSITIVE_INFINITY) {
         return chebyshevDistance(x, y, lx, p, Math.max);
-      }
-      else if (p === Number.NEGATIVE_INFINITY) {
+      } else if (p === Number.NEGATIVE_INFINITY) {
         return chebyshevDistance(x, y, lx, p, Math.min);
-      }
-      else if (p < 1) {
+      } else if (p < 1) {
         throw 'p less than 1 will violate triangle inequality';
-      }
-      else {
+      } else {
         d = 0;
 
-        for (i = 0; i < lx; i++) {
+        for (i = 0; i < lx; i += 1) {
           d += Math.pow(Math.abs(x[i] - y[i]), p);
         }
 
         return isNaN(d)
           ? 0
-          : Math.pow(d, 1/p);
+          : Math.pow(d, 1 / p);
+
       }
 
     }
 
-
     /**
-     * The Minkowski distance between two points gets generalized 
+     * The Minkowski distance between two points gets generalized
      * metric distance
-     * 
      * when p === 1, this becomes same as Manhattan Distance
      * when p === 2, this becomes same as Euclidean Distance
      * when p === Positive or Negative Infinity,
@@ -66,7 +62,7 @@
      * var dist = require('path-to-algorithms/src/others/' +
      * 'minkowski-distance').minkowskiDistance;
      * console.log(dist([0, 1], [1, 1], 2)); // 1
-     * 
+     *
      * @param {Array} x source point
      * @param {Array} y target point
      * @param {Number} p order of Minkowski distance
@@ -75,10 +71,9 @@
      */
     return function (x, y, p) {
       return minkowskiDistance (x, x.length, y, y.length, p);
-    }
+    };
   }());
 
-
   exports.minkowskiDistance = minkowskiDistance;
 
-}(typeof exports === 'undefined' ? window : exports));
+}(typeof exports === 'undefined' ? window : exports));

test/others/minkowski-distance.spec.js

@@ -20,22 +20,22 @@ describe('Minkowski Distance', function () {
     expect(minkowskiDistance([0, 1, 4], [1, 1, 6], Number.NEGATIVE_INFINITY)).toBe(0);
   });
   it('should throw when 2 points are not in equal length', function () {
-    expect( function () {
+    expect(function () {
       minkowskiDistance([1, 2], [1], 1)
     }).toThrow('2 points must have same array length');
   });
   it('should throw when p is not defined', function () {
-    expect( function () {
+    expect(function () {
       minkowskiDistance([1, 2], [1, 2])
     }).toThrow('p must be a number');
   });
   it('should throw when p is not a number', function () {
-    expect( function () {
+    expect(function () {
       minkowskiDistance([1, 2], [1, 2], NaN)
     }).toThrow('p must be a number');
   });
   it('should throw when p is less than 1', function () {
-    expect( function () {
+    expect(function () {
       minkowskiDistance([1, 2], [1, 2], 0)
     }).toThrow('p less than 1 will violate triangle inequality');
   });