Fix a qucik sort - declarative

Author: mik-laj

src/sorting/quicksort-declarative.js

@@ -21,18 +21,18 @@
      * @private
      * @param {array} array Array which should be processed
      */
-    function quickSort(array, cmp) {
+    function quicksort(array, cmp) {
       if (array.length < 1) {
-        return arr;
+        return array;
       }
 
-      const [x, ...rest] = arr;
+      const [x, ...rest] = array;
 
       return [
-          ...quickSort(rest.filter(v => cmp(v, x) < 0)),
-          x,
-          ...quickSort(rest.filter(v => cmp(v, x) >= 0))
-      ]
+        ...quicksort(rest.filter(v => cmp(v, x) < 0), cmp),
+        x,
+        ...quicksort(rest.filter(v => cmp(v, x) >= 0), cmp)
+      ];
     }
 
 
@@ -57,7 +57,7 @@
      */
     return function (array, cmp) {
       cmp = cmp || compare;
-      quickSort(array, 0, array.length - 1, cmp);
+      array = quicksort(array, cmp);
       return array;
     };
 

test/sorting/sort.testcase.js

@@ -39,7 +39,7 @@ module.exports = function (sort, algorithmName, options) {
           precision: 0
         });
       }
-      sort(array);
+      array = sort(array);
       for (var i = 0; i < array.length - 1; i += 1) {
         expect(array[i] <= array[i + 1]).toBeTruthy();
       }
@@ -53,7 +53,7 @@ module.exports = function (sort, algorithmName, options) {
         }
 
         var array = createRandomArray();
-        sort(array, comparator);
+        array = sort(array, comparator);
 
         for (var i = 0; i < array.length - 1; i += 1) {
           expect(array[i] >= array[i + 1]).toBeTruthy();