Isomorphic-render: Add guards around global objects

Author: addyosmani

src/App.js

@@ -1,4 +1,3 @@
-/* global __VERSION__ */
 var React = require('react')
 var Link = require('react-router/lib/Link')
 
@@ -19,10 +18,12 @@ var App = React.createClass({
     SettingsStore.load()
     StoryStore.loadSession()
     UpdatesStore.loadSession()
+    if (typeof window === 'undefined') return
     window.addEventListener('beforeunload', this.handleBeforeUnload)
   },
 
   componentWillUnmount() {
+    if (typeof window === 'undefined') return
     window.removeEventListener('beforeunload', this.handleBeforeUnload)
   },
 
@@ -60,7 +61,6 @@ var App = React.createClass({
         {this.props.children}
       </div>
       <div className="App__footer">
-        {`react-hn v${__VERSION__} | `}
         <a href="https://github.com/insin/react-hn">insin/react-hn</a>
       </div>
       </div>

src/stores/StoryStore.js

@@ -99,6 +99,7 @@ class StoryStore extends EventEmitter {
   start() {
     firebaseRef = HNService.storiesRef(this.type)
     firebaseRef.on('value', this.onStoriesUpdated)
+    if (typeof window === 'undefined') return
     window.addEventListener('storage', this.onStorage)
   }
 
@@ -107,6 +108,7 @@ class StoryStore extends EventEmitter {
       firebaseRef.off()
       firebaseRef = null
     }
+    if (typeof window === 'undefined') return
     window.removeEventListener('storage', this.onStorage)
   }
 }
@@ -124,6 +126,7 @@ extend(StoryStore, {
    * Deserialise caches from sessionStorage.
    */
   loadSession() {
+    if (typeof window === 'undefined') return
     idCache = parseJSON(window.sessionStorage.idCache, {})
     itemCache = parseJSON(window.sessionStorage.itemCache, {})
   },
@@ -132,6 +135,7 @@ extend(StoryStore, {
    * Serialise caches to sessionStorage as JSON.
    */
   saveSession() {
+    if (typeof window === 'undefined') return
     window.sessionStorage.idCache = JSON.stringify(idCache)
     window.sessionStorage.itemCache = JSON.stringify(itemCache)
   }

src/stores/UpdatesStore.js

@@ -100,12 +100,14 @@ function handleUpdateItems(items) {
 
 var UpdatesStore = extend(new EventEmitter(), {
   loadSession() {
+    if (typeof window === 'undefined') return
     var json = window.sessionStorage.updates
     updatesCache = (json ? JSON.parse(json) : {comments: {}, stories: {}})
     populateUpdates()
   },
 
   saveSession() {
+    if (typeof window === 'undefined') return
     window.sessionStorage.updates = JSON.stringify(updatesCache)
   },
 

src/utils/setTitle.js

@@ -1,6 +1,7 @@
 var {SITE_TITLE} = require('./constants')
 
 function setTitle(title) {
+  if (typeof document === 'undefined') return
   document.title = (title ? title + ' | ' + SITE_TITLE : SITE_TITLE)
 }
 

src/utils/storage.js

@@ -1,9 +1,14 @@
 module.exports = {
   get(key, defaultValue) {
-    var value = window.localStorage[key]
-    return (typeof value != 'undefined' ? value : defaultValue)
+    if (typeof window !== 'undefined') {
+      var value = window.localStorage[key]
+      return (typeof value != 'undefined' ? value : defaultValue)
+    }
   },
   set(key, value) {
-    window.localStorage[key] = value
+    if (typeof window !== 'undefined') {
+      window.localStorage[key] = value
+    }
   }
 }
+