Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: insin/react-hn
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: classic
Choose a base ref
...
head repository: insin/react-hn
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: update-latest-deps
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 20 commits
  • 14 files changed
  • 1 contributor

Commits on Oct 3, 2016

  1. Add babelrc

    @addyosmani
    addyosmani committed Oct 3, 2016
    Configuration menu
    Copy the full SHA
    7e5ad19 View commit details
    Browse the repository at this point in the history

  2. Add list to gitignore

    @addyosmani
    addyosmani committed Oct 3, 2016
    Configuration menu
    Copy the full SHA
    cfa5f17 View commit details
    Browse the repository at this point in the history

  3. Update nwb.config to latest loader, babel requirements

    @addyosmani
    addyosmani committed Oct 3, 2016
    Configuration menu
    Copy the full SHA
    24223b5 View commit details
    Browse the repository at this point in the history

  4. Bump package.json to latest deps

    @addyosmani
    addyosmani committed Oct 3, 2016
    Configuration menu
    Copy the full SHA
    47510df View commit details
    Browse the repository at this point in the history

  5. Update syntax to match dependencies

    @addyosmani
    addyosmani committed Oct 3, 2016
    Configuration menu
    Copy the full SHA
    232a92a View commit details
    Browse the repository at this point in the history

  6. Comment out React hash history for now

    @addyosmani
    addyosmani committed Oct 3, 2016
    Configuration menu
    Copy the full SHA
    70cfa8a View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2016

  1. Update dependencies and paths to deps

    @addyosmani
    addyosmani committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    e4ee6c3 View commit details
    Browse the repository at this point in the history

  2. Add HtmlWebpackPlugin for re-wiring up template output

    @addyosmani
    addyosmani committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    52e9381 View commit details
    Browse the repository at this point in the history

  3. Update wiring and EJS templates to include runtime 

    TODO: Figure out how to properly pull in the runtime during builds like
this where EJS templates are used
    @addyosmani
    addyosmani committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    c768de5 View commit details
    Browse the repository at this point in the history

  4. Paths changed from public -> dist for final output 

    I’m actually unsure why these changed. I think nwb now prescribes a
particular directory name by default but need to dig into this further.
    @addyosmani
    addyosmani committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    311da4b View commit details
    Browse the repository at this point in the history

  5. Update syntax to Firebase 3.0

    @addyosmani
    addyosmani committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    1875c9a View commit details
    Browse the repository at this point in the history

  6. Temp fix for missing manifest in builds

    @addyosmani
    addyosmani committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    0aeb0f5 View commit details
    Browse the repository at this point in the history

  7. Trim 60KB off the total gzipped build size by modularizing

    @addyosmani
    addyosmani committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    131462b View commit details
    Browse the repository at this point in the history

  8. nwb config: 'all' > true

    @addyosmani
    addyosmani committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    c6d3d37 View commit details
    Browse the repository at this point in the history

  9. Hotfix: fix nwb creating an index.html we don't want 

    This is due to some default introduced that interacts with
HtmlWebpackPlugin to generate an index.html file. I’m unsure how to
turn it off after reading the docs. It’s also unclear if the escape
hatch use of Webpack extras is invoking something it shouldn’t be.
    @addyosmani
    addyosmani committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    b4869b8 View commit details
    Browse the repository at this point in the history

  10. config: drop the workaround. Didn't actually work around

    @addyosmani
    addyosmani committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    3cf8041 View commit details
    Browse the repository at this point in the history

  11. Fix the mess that has been rewiring markup 

    We had a number of issues populating the SSR only view with data. This
worked fine in the pre-update deps version of the codebase but due to
some weirdness with how nwb interacts with htmlwebpack plugin and
having to pass templates around, needed to fix it this way. works.
    @addyosmani
    addyosmani committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    6a48ab8 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2016

  1. Remove inline runtime

    @addyosmani
    addyosmani committed Oct 9, 2016
    Configuration menu
    Copy the full SHA
    bc684a9 View commit details
    Browse the repository at this point in the history

  2. Refactor route-chunking a little

    @addyosmani
    addyosmani committed Oct 9, 2016
    Configuration menu
    Copy the full SHA
    d1e298b View commit details
    Browse the repository at this point in the history

  3. Add the commonschunkplugin

    @addyosmani
    addyosmani committed Oct 9, 2016
    Configuration menu
    Copy the full SHA
    91f2bdc View commit details
    Browse the repository at this point in the history
Loading