! fix: indexing in get_first_worker_that_is_not_equal_to_self (#150)

clangenb · web-flow · commit 1138cce23356 · 2020-05-30T08:07:29.000+02:00
diff --git a/substratee-node-primitives/src/lib.rs b/substratee-node-primitives/src/lib.rs
@@ -65,8 +65,9 @@ pub mod calls {
     where
         MultiSignature: From<P::Signature>,
     {
-        for n in 0..api.get_storage_value("SubstrateeRegistry", "EnclaveCount", None)? {
-            let worker = get_worker_info(api, n)?;
+        // the registry starts indexing its map at one
+        for n in 1..=api.get_storage_value("SubstrateeRegistry", "EnclaveCount", None)? {
+            let worker = get_worker_info(api, n).unwrap();
             if &worker.pubkey != self_account {
                 return Some(worker);
             }

Original file line number	Diff line number	Diff line change
`@@ -65,8 +65,9 @@ pub mod calls {`
`65`	`65`	`where`
`66`	`66`	`MultiSignature: From<P::Signature>,`
`67`	`67`	`{`
`68`		`- for n in 0..api.get_storage_value("SubstrateeRegistry", "EnclaveCount", None)? {`
`69`		`- let worker = get_worker_info(api, n)?;`
	`68`	`+ // the registry starts indexing its map at one`
	`69`	`+ for n in 1..=api.get_storage_value("SubstrateeRegistry", "EnclaveCount", None)? {`
	`70`	`+ let worker = get_worker_info(api, n).unwrap();`
`70`	`71`	`if &worker.pubkey != self_account {`
`71`	`72`	`return Some(worker);`
`72`	`73`	`}`