KVReplayGenerator: parse GET_LEASE and SET_LEASE operations

Summary:
Memcached's WSA logger will now emits GET_LEASE and SET_LEASE operations as well. This changes makes
the cachebench treats those as GET and SET, respectively, for compatibility.

Reviewed By: therealgymmy

Differential Revision: D43336316

fbshipit-source-id: c9b842d567b9fb2128b822bd429f5dce30b378da

Author: Jaesoo Lee

cachelib/cachebench/workload/KVReplayGenerator.h

@@ -230,10 +230,10 @@ inline bool KVReplayGenerator::parseRequest(const std::string& line,
 
   // Set op
   const auto& op = fields[SampleFields::OP];
-  // TODO only memcache optypes are supported
-  if (!op.compare("GET")) {
+  // TODO implement GET_LEASE and SET_LEASE emulations
+  if (!op.compare("GET") || !op.compare("GET_LEASE")) {
     req->req_.setOp(OpType::kGet);
-  } else if (!op.compare("SET")) {
+  } else if (!op.compare("SET") || !op.compare("SET_LEASE")) {
     req->req_.setOp(OpType::kSet);
   } else if (!op.compare("DELETE")) {
     req->req_.setOp(OpType::kDel);

cachelib/cachebench/workload/tests/KVReplayGeneratorTest.cpp

@@ -56,6 +56,18 @@ struct TraceEntry {
     size_t expKeySize = std::max<size_t>(keySize_, reqKey.size());
     expKeySize = std::min<size_t>(expKeySize, 256);
     ASSERT_EQ(reqKey.size(), expKeySize);
+    ASSERT_EQ(req.req_.getOp(), getOpType());
+  }
+
+  OpType getOpType() {
+    if (!op_.compare("GET") || !op_.compare("GET_LEASE")) {
+      return OpType::kGet;
+    } else if (!op_.compare("SET") || !op_.compare("SET_LEASE")) {
+      return OpType::kSet;
+    } else if (!op_.compare("DELETE")) {
+      return OpType::kDel;
+    }
+    return OpType::kSize;
   }
 
   std::string key_;
@@ -86,8 +98,11 @@ TEST(KVReplayGeneratorTest, BasicFormat) {
       // <key_size>,<op>,<size>,<op_count>,<ttl>,<valid>
       {7, "GET", 0, 2, std::nullopt, true},
       {7, "GET", 0, 2, 50, true},
+      {7, "GET_LEASE", 0, 2, 50, true},
       {20, "SET", 100, 35, std::nullopt, true},
       {20, "SET", 100, 35, 3600, true},
+      {20, "SAT", 100, 35, 3600, false}, // invalid op name
+      {20, "SET_LEASE", 100, 35, 3600, true},
       {7, "GET", 0, 0, std::nullopt, false},      // invalid op count
       {7, "GET", 0, 0, 600, false},               // invalid op count
       {1024, "SET", 100, 35, 300, true},          // key truncated