Merged
Conversation
fe75025 to
136d5ba
Compare
Collaborator
Author
Creating Token$ globe token create --name="Token" --expiry="2012-02-12" --project 8325e5a6-e419-45cb-99bd-3549880b1b26or $ globe token create --name="Token" --expiry="2012-02-12"
Select projects to associate token with:
❯ ◯ pizza-store
◯ zomato
◯ blog-backendTerminal display when token created$ globe token create --name="Token" --expiry="2012-02-12"
Select projects to associate token with: [zomato, pizza-app]
✓ Here's your token:
ID: 5c65febd-0185-4dca-9032-a4e3bdc8be4b
Token: foo-bar.token-goes.here (1.8s)Terminal display when invalid expiry format$ globe token create --name="Token" --expiry="2012"
Invalid date format.
Date format should be 2012-02-27 or 2012-02-27 13:27:00Deleting Token$ globe token delete --tokenId="5c65febd-0185-4dca-9032-a4e3bdc8be4b"Screen.Recording.2024-02-12.at.11.14.12.AM.mov |
15f81e9 to
5e5f602
Compare
Collaborator
Author
Collaborator
Author
|
This is no longer blocked, @lesnitsky we can proceed with review. |
lesnitsky
suggested changes
Feb 19, 2024
packages/globe_cli/lib/src/commands/token/token_create_command.dart
Outdated
Show resolved
Hide resolved
lesnitsky
reviewed
Feb 19, 2024
packages/globe_cli/lib/src/commands/token/token_delete_command.dart
Outdated
Show resolved
Hide resolved
Contributor
|
|
Contributor
|
We'd also need a way to list tokens and see what projects a specific token has access to. Do you want to take care of it in this PR or separately? |
Collaborator
Author
Yeah, we'll have it in here. |
lesnitsky
approved these changes
Feb 21, 2024
exaby73
suggested changes
Feb 21, 2024
Co-authored-by: Nabeel Parkar <nabeelparkar99@gmail.com>
Co-authored-by: Nabeel Parkar <nabeelparkar99@gmail.com>
Co-authored-by: Nabeel Parkar <nabeelparkar99@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: https://github.com/invertase/dart_globe/issues/134