Adding a test for undefined value in OutgoingMessage.setHeader #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a result of 979d0ca there is a new check for undefined values on OutgoingMessage.setHeader. This commit introduces a test for this case.
|
lgtm |
There was a problem hiding this comment.
Why not just use assert.throws()?
There was a problem hiding this comment.
I just quickly duplicated the section above. I'm open to suggestions here.
There was a problem hiding this comment.
IMO it would make more sense to use assert.throws() with a validation function like:
function(err) {
return err instanceof Error && err.message === '`value` required in setHeader("foo", value).';
}
There was a problem hiding this comment.
Truth be told, I think the try/catch is more readable.
There was a problem hiding this comment.
as it is the same style as the above section, @cjihrig would you object to me merging this in as-is?
There was a problem hiding this comment.
@brendanashworth go for it.
|
looks good to me |
brendanashworth
pushed a commit
that referenced
this pull request
Mar 5, 2015
As a result of 979d0ca there is a new check for undefined values on OutgoingMessage.setHeader. This commit introduces a test for this case. PR-URL: #970 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Brendan Ashworth <[email protected]>
|
Thanks @kenperkins, merged in |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of 979d0ca there is a new check for
undefinedvalues onOutgoingMessage.setHeader. This commit introduces a test for this case.