test: don't spawn child processes in domain test #974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
It's very peculiar but if firstRun is not last, errors == 4 instead of 5...
There was a problem hiding this comment.
That seems ... bizarre.
|
LGTM. The ordering issue might bear more looking into. |
Turn counter macros into no-op instructions when counters are disabled.
Evaluating to nothing makes gcc complain when the macro is used in a
conditional. Fixes the following warning:
../src/tls_wrap.cc:320:5: warning:
suggest braces around empty body in an 'if' statement [-Wempty-body]
NODE_COUNT_NET_BYTES_SENT(write_size_);
^
PR-URL: nodejs#974
Reviewed-By: Chris Dickinson <[email protected]>
Make parallel/test-domain-abort-on-uncaught a little easier to debug, make it execute the tests in the same process instead of each test in a separate child process. PR-URL: nodejs#974 Reviewed-By: Chris Dickinson <[email protected]>
bnoordhuis
force-pushed
the
simplify-domains-test
branch
from
df537e4 to
7b554b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make parallel/test-domain-abort-on-uncaught a little easier to debug,
make it execute the tests in the same process instead of each test in
a separate child process.
R=@chrisdickinson
https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/202/