From 4cd503a1a2a1226d1f3a0c531aa2a71bf40be9f8 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Thu, 24 Jan 2019 16:46:05 -0500 Subject: [PATCH 1/5] docs(readme): update readme with nightly build instructions --- README.md | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/README.md b/README.md index 628422b0..c4f7edf6 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,6 @@ [![npm version](https://img.shields.io/npm/v/@ionic/app-scripts.svg)](https://www.npmjs.com/package/@ionic/app-scripts) [![Circle CI](https://circleci.com/gh/ionic-team/ionic-app-scripts.svg?style=shield&circle-token=:circle-token)](https://circleci.com/gh/ionic-team/ionic-app-scripts) + # Ionic App Scripts Helper scripts to get [Ionic apps](https://ionicframework.com/) up and running quickly (minus the config overload). @@ -251,17 +252,27 @@ We welcome any PRs, issues, and feedback! Please be respectful and follow the [C We use Node 6, and NPM 5 for contributing. +### Publish a Nightly Build + +1. Run `npm run build` to generate the `dist` directory +2. Run `npm run test` to validate the `dist` works +3. Tick the `package.json` version +4. Run `npm run nightly` to generate a nightly build on npm + + + ### Publish a release Execute the following steps to publish a release: -1. Run `npm run build` to generate the `dist` directory -2. Run `npm run test` to validate the `dist` works -3. Temporarily tick the `package.json` version -4. Run `npm run changelog` to append the latest additions to the changelog -5. Manually verify and commit the changelog changes. Often times you'll want to manually add content/instructions -6. Revert the `package.json` version to the original version -7. Run `npm version patch` to tick the version and generate a git tag -8. Run `npm run github-release` to create the github release entry -9. Run `npm publish` to publish the package to npm -10. `git push origin master` - push changes to master +1. Ensure your branch has been merged into `master` +2. Run `npm run build` to generate the `dist` directory +3. Run `npm run test` to validate the `dist` works +4. Temporarily tick the `package.json` version +5. Run `npm run changelog` to append the latest additions to the changelog +6. Manually verify and commit the changelog changes. Often times you'll want to manually add content/instructions +7. Revert the `package.json` version to the original version +8. Run `npm version patch` to tick the version and generate a git tag +9. Run `npm run github-release` to create the github release entry +10. Run `npm publish` to publish the package to npm +11. `git push origin master` - push changes to master \ No newline at end of file From fe25c33365f5397e495c1a0603c202624a3ed513 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Tue, 29 Jan 2019 10:49:12 -0500 Subject: [PATCH 2/5] Revert "docs(readme): update readme with nightly build instructions" (#1509) --- README.md | 31 ++++++++++--------------------- 1 file changed, 10 insertions(+), 21 deletions(-) diff --git a/README.md b/README.md index c4f7edf6..628422b0 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,5 @@ [![npm version](https://img.shields.io/npm/v/@ionic/app-scripts.svg)](https://www.npmjs.com/package/@ionic/app-scripts) [![Circle CI](https://circleci.com/gh/ionic-team/ionic-app-scripts.svg?style=shield&circle-token=:circle-token)](https://circleci.com/gh/ionic-team/ionic-app-scripts) - # Ionic App Scripts Helper scripts to get [Ionic apps](https://ionicframework.com/) up and running quickly (minus the config overload). @@ -252,27 +251,17 @@ We welcome any PRs, issues, and feedback! Please be respectful and follow the [C We use Node 6, and NPM 5 for contributing. -### Publish a Nightly Build - -1. Run `npm run build` to generate the `dist` directory -2. Run `npm run test` to validate the `dist` works -3. Tick the `package.json` version -4. Run `npm run nightly` to generate a nightly build on npm - - - ### Publish a release Execute the following steps to publish a release: -1. Ensure your branch has been merged into `master` -2. Run `npm run build` to generate the `dist` directory -3. Run `npm run test` to validate the `dist` works -4. Temporarily tick the `package.json` version -5. Run `npm run changelog` to append the latest additions to the changelog -6. Manually verify and commit the changelog changes. Often times you'll want to manually add content/instructions -7. Revert the `package.json` version to the original version -8. Run `npm version patch` to tick the version and generate a git tag -9. Run `npm run github-release` to create the github release entry -10. Run `npm publish` to publish the package to npm -11. `git push origin master` - push changes to master \ No newline at end of file +1. Run `npm run build` to generate the `dist` directory +2. Run `npm run test` to validate the `dist` works +3. Temporarily tick the `package.json` version +4. Run `npm run changelog` to append the latest additions to the changelog +5. Manually verify and commit the changelog changes. Often times you'll want to manually add content/instructions +6. Revert the `package.json` version to the original version +7. Run `npm version patch` to tick the version and generate a git tag +8. Run `npm run github-release` to create the github release entry +9. Run `npm publish` to publish the package to npm +10. `git push origin master` - push changes to master From aeef5ee44985ad7c6501df624d64e2f93028ceab Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Tue, 29 Jan 2019 11:06:11 -0500 Subject: [PATCH 3/5] docs(readme): update readme with nightly build instructions (#1510) --- README.md | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/README.md b/README.md index 628422b0..c4f7edf6 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,6 @@ [![npm version](https://img.shields.io/npm/v/@ionic/app-scripts.svg)](https://www.npmjs.com/package/@ionic/app-scripts) [![Circle CI](https://circleci.com/gh/ionic-team/ionic-app-scripts.svg?style=shield&circle-token=:circle-token)](https://circleci.com/gh/ionic-team/ionic-app-scripts) + # Ionic App Scripts Helper scripts to get [Ionic apps](https://ionicframework.com/) up and running quickly (minus the config overload). @@ -251,17 +252,27 @@ We welcome any PRs, issues, and feedback! Please be respectful and follow the [C We use Node 6, and NPM 5 for contributing. +### Publish a Nightly Build + +1. Run `npm run build` to generate the `dist` directory +2. Run `npm run test` to validate the `dist` works +3. Tick the `package.json` version +4. Run `npm run nightly` to generate a nightly build on npm + + + ### Publish a release Execute the following steps to publish a release: -1. Run `npm run build` to generate the `dist` directory -2. Run `npm run test` to validate the `dist` works -3. Temporarily tick the `package.json` version -4. Run `npm run changelog` to append the latest additions to the changelog -5. Manually verify and commit the changelog changes. Often times you'll want to manually add content/instructions -6. Revert the `package.json` version to the original version -7. Run `npm version patch` to tick the version and generate a git tag -8. Run `npm run github-release` to create the github release entry -9. Run `npm publish` to publish the package to npm -10. `git push origin master` - push changes to master +1. Ensure your branch has been merged into `master` +2. Run `npm run build` to generate the `dist` directory +3. Run `npm run test` to validate the `dist` works +4. Temporarily tick the `package.json` version +5. Run `npm run changelog` to append the latest additions to the changelog +6. Manually verify and commit the changelog changes. Often times you'll want to manually add content/instructions +7. Revert the `package.json` version to the original version +8. Run `npm version patch` to tick the version and generate a git tag +9. Run `npm run github-release` to create the github release entry +10. Run `npm publish` to publish the package to npm +11. `git push origin master` - push changes to master \ No newline at end of file From 8870a170f0701ce05f1a297ac00043500d98cdb2 Mon Sep 17 00:00:00 2001 From: intodevelopment <6976899+intodevelopment@users.noreply.github.com> Date: Fri, 1 Mar 2019 14:43:22 +0100 Subject: [PATCH 4/5] fix(livereload): find all bundles to update HTML template of components is not updated by ionic serve after saving the file. When a module is shared among multiple modules, e.g., a components module, the component template is present in multiple bundle files, so the template should be replaced in all bundle files. --- src/template.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/template.ts b/src/template.ts index 101c6bd5..27c52b32 100644 --- a/src/template.ts +++ b/src/template.ts @@ -22,13 +22,12 @@ export function templateUpdate(changedFiles: ChangedFile[], context: BuildContex if (!updateCorrespondingJsFile(context, file.content, changedTemplateFile.filePath)) { throw new Error(`Failed to inline template ${changedTemplateFile.filePath}`); } - // find the corresponding bundle + // find the corresponding bundles for (const bundleFile of bundleFiles) { const newContent = replaceExistingJsTemplate(bundleFile.content, file.content, changedTemplateFile.filePath); if (newContent && newContent !== bundleFile.content) { context.fileCache.set(bundleFile.path, { path: bundleFile.path, content: newContent}); writeFileSync(bundleFile.path, newContent); - break; } } } From 5d7ca3825e1aada6a9457a98572d4e86d5e4b0e6 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Fri, 1 Mar 2019 08:46:36 -0500 Subject: [PATCH 5/5] chore(): release 3.2.3 --- CHANGELOG.md | 10 ++++++++++ package.json | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1f2ebef0..fcae0db4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,13 @@ + +## [3.2.3](https://github.com/ionic-team/ionic-app-scripts/compare/v3.2.2...v3.2.3) (2019-03-01) + + +### Bug Fixes + +* **livereload:** fix issue with files not reloading([8870a17](https://github.com/ionic-team/ionic-app-scripts/commit/8870a17)) + + + ## [3.2.2](https://github.com/ionic-team/ionic-app-scripts/compare/v3.2.1...v3.2.2) (2019-01-22) diff --git a/package.json b/package.json index 65612dcd..4698e3f8 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@ionic/app-scripts", - "version": "3.2.2", + "version": "3.2.3", "description": "Scripts for Ionic Projects", "homepage": "https://ionicframework.com/", "author": "Ionic Team (https://ionic.io)",