Skip to content

bitswap/httpnet: do not follow redirects #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025
Merged

bitswap/httpnet: do not follow redirects #878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8577bd7
bitswap/httpnet: do not follow redirects
hsanjuan Mar 10, 2025
cafa7e2
bitswap/httpnet: close response bodies
hsanjuan Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions bitswap/network/httpnet/httpnet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,12 @@ func New(host host.Host, opts ...Option) network.BitSwapNetwork {

c := &http.Client{
Transport: t,
CheckRedirect: func(req *http.Request, via []*http.Request) error {
// we do not follow redirects. Providers should keep
// announcements up to
// date. https://github.com/boxo/issues/862.
return http.ErrUseLastResponse
},
}
htnet.client = c

Expand Down
8 changes: 7 additions & 1 deletion bitswap/network/httpnet/msg_sender.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ func (sender *httpMsgSender) tryURL(ctx context.Context, u *senderURL, entry bsm

return nil, serr
}
defer resp.Body.Close()

// Record request size
var buf bytes.Buffer
Expand Down Expand Up @@ -302,7 +303,12 @@ func (sender *httpMsgSender) tryURL(ctx context.Context, u *senderURL, entry bsm
case http.StatusNotFound,
http.StatusGone,
http.StatusForbidden,
http.StatusUnavailableForLegalReasons:
http.StatusUnavailableForLegalReasons,
http.StatusMovedPermanently,
http.StatusFound,
http.StatusSeeOther,
http.StatusTemporaryRedirect,
http.StatusPermanentRedirect:

err := fmt.Errorf("%s %q -> %d: %q", req.Method, req.URL, statusCode, string(body))
log.Debug(err)
Expand Down
Loading