Skip to content

fix: Issue #9364 JSON config validation #10679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guillaumemichel merged 32 commits into from
Feb 4, 2025
Merged

fix: Issue #9364 JSON config validation #10679

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
c5649c2
Fix JSON config validation
gsergey418 Jan 28, 2025
b69676b
Add changelog entry.
gsergey418 Jan 28, 2025
42692c6
Fix test
gsergey418 Jan 28, 2025
f589555
Fix more tests, 53 still failing
gsergey418 Jan 28, 2025
c35ee66
Remove JSON test due to fragilty, fix some more tests, Lib tests left.
gsergey418 Jan 28, 2025
dd9627e
Remove lib tests as they don't seem to be relevant anymore.
gsergey418 Jan 28, 2025
f7b44d0
Move changelog into v0.34
gsergey418 Jan 28, 2025
11f7f06
Fix config validation.
gsergey418 Jan 29, 2025
ef3ff89
Delete test file
gsergey418 Jan 29, 2025
7b88c81
Use reflection to ignore encoding/json tags.
gsergey418 Jan 29, 2025
2765ec0
Add exceptions for fields that were already maps in the config, fix o…
gsergey418 Jan 29, 2025
354256a
Fix last (hopefully) test
gsergey418 Jan 29, 2025
12a0185
test: fix the socat tests after the ubuntu 24.04 upgrade
galargh Jan 29, 2025
c546382
Merge branch 'socat-ubuntu-noble' of https://github.com/ipfs/kubo int…
gsergey418 Jan 29, 2025
a091fbe
Merge branch 'master' into fix/9364-validation
guillaumemichel Jan 29, 2025
ab2657e
Merge branch 'master' into fix/9364-validation
guillaumemichel Jan 30, 2025
af0c5c6
docker sharness
guillaumemichel Jan 30, 2025
7a3732f
updated ReflectToMap
guillaumemichel Jan 31, 2025
9086971
Fix nested maps and write a test for it.
gsergey418 Jan 31, 2025
564d9dd
Add tests for other data types
gsergey418 Jan 31, 2025
c34c068
Revert "Fix nested maps and write a test for it."
gsergey418 Feb 3, 2025
44fbd88
Validate structs nested in maps.
gsergey418 Feb 3, 2025
8a669cd
Add comments.
gsergey418 Feb 3, 2025
0a25331
Remove debug
gsergey418 Feb 3, 2025
eae4382
Add test for PublicGateways
gsergey418 Feb 3, 2025
7e8d3ca
Add test for sturct in map
gsergey418 Feb 3, 2025
db3cd49
Merge branch 'master' into fix/9364-validation
guillaumemichel Feb 4, 2025
bed120f
comment typo
guillaumemichel Feb 4, 2025
69235e2
slight refactor
guillaumemichel Feb 4, 2025
8e72a65
Add CheckKey tests.
gsergey418 Feb 4, 2025
87e42d8
Add handling for interface{} in the config
gsergey418 Feb 4, 2025
7d7633e
"any" -> nil
gsergey418 Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests for other data types
  • Loading branch information
@gsergey418
gsergey418 committed Jan 31, 2025
commit 564d9dd5d29ac069be6500af12926f2304dc98ce
3 changes: 3 additions & 0 deletions test/sharness/t0021-config.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ test_config_cmd() {
test_config_cmd_set "Addresses.API" "foo"
test_config_cmd_set "Addresses.Gateway" "bar"
test_config_cmd_set "Datastore.GCPeriod" "baz"
test_config_cmd_set "AutoNAT.ServiceMode" "enabled"
test_config_cmd_set "--bool" "Discovery.MDNS.Enabled" "true"
test_config_cmd_set "--bool" "Discovery.MDNS.Enabled" "false"
test_config_cmd_set "--json" "Datastore.HashOnRead" "true"
Expand All @@ -80,6 +81,8 @@ test_config_cmd() {
test_config_cmd_set "--json" "Import.BatchMaxSize" "null"
test_config_cmd_set "--json" "Import.UnixFSRawLeaves" "true"
test_config_cmd_set "--json" "Routing.Routers.Test" "{\\\"Parameters\\\":\\\"Test\\\",\\\"Type\\\":\\\"Test\\\"}"
test_config_cmd_set "--json" "Experimental.OptimisticProvideJobsPoolSize" "1337"
test_config_cmd_set "--json" "Addresses.Swarm" "[\\\"test\\\",\\\"test\\\",\\\"test\\\"]"

test_expect_success "'ipfs config show' works" '
ipfs config show >actual
Expand Down