Remove obsolete lint of by-name-right-assoc

Author: som-snytt

src/compiler/scala/tools/nsc/settings/Warnings.scala

@@ -93,7 +93,6 @@ trait Warnings {
     val PolyImplicitOverload   = LintWarning("poly-implicit-overload",    "Parameterized overloaded implicit methods are not visible as view bounds.")
     val OptionImplicit         = LintWarning("option-implicit",           "Option.apply used implicit view.")
     val DelayedInitSelect      = LintWarning("delayedinit-select",        "Selecting member of DelayedInit.")
-    val ByNameRightAssociative = LintWarning("by-name-right-associative", "By-name parameter of right associative operator.")
     val PackageObjectClasses   = LintWarning("package-object-classes",    "Class or object defined in package object.")
     val StarsAlign             = LintWarning("stars-align",               "Pattern sequence wildcard must align with sequence component.")
     val Constant               = LintWarning("constant",                  "Evaluation of a constant arithmetic expression results in an error.")
@@ -116,7 +115,6 @@ trait Warnings {
   def warnPolyImplicitOverload   = lint contains PolyImplicitOverload
   def warnOptionImplicit         = lint contains OptionImplicit
   def warnDelayedInit            = lint contains DelayedInitSelect
-  def warnByNameRightAssociative = lint contains ByNameRightAssociative
   def warnPackageObjectClasses   = lint contains PackageObjectClasses
   def warnStarsAlign             = lint contains StarsAlign
   def warnConstant               = lint contains Constant

src/compiler/scala/tools/nsc/typechecker/RefChecks.scala

@@ -1337,16 +1337,6 @@ abstract class RefChecks extends Transform {
       member.typeParams.map(_.info.bounds.hi.widen) foreach checkAccessibilityOfType
     }
 
-    private def checkByNameRightAssociativeDef(tree: DefDef): Unit = {
-      tree match {
-        case DefDef(_, name, _, params :: _, _, _) =>
-          if (settings.warnByNameRightAssociative && !nme.isLeftAssoc(name.decodedName) && params.exists(p => isByName(p.symbol)))
-            reporter.warning(tree.pos,
-              "by-name parameters will be evaluated eagerly when called as a right-associative infix operator. For more details, see scala/bug#1980.")
-        case _ =>
-      }
-    }
-
     /** Check that a deprecated val or def does not override a
       * concrete, non-deprecated method.  If it does, then
       * deprecation is meaningless.
@@ -1677,20 +1667,16 @@ abstract class RefChecks extends Transform {
                 checkAccessibilityOfReferencedTypes(tree)
             }
             tree match {
-              case dd: DefDef =>
-                checkByNameRightAssociativeDef(dd)
-
-                if (sym hasAnnotation NativeAttr) {
-                  if (sym.owner.isTrait) {
-                    reporter.error(tree.pos, "A trait cannot define a native method.")
-                    tree
-                  } else if (dd.rhs == EmptyTree) {
-                    // pretend it had a stub implementation
-                    sym resetFlag DEFERRED
-                    deriveDefDef(dd)(_ => typed(gen.mkThrowNewRuntimeException("native method stub")))
-                  } else tree
-                } else tree
-
+              case dd: DefDef if sym.hasAnnotation(NativeAttr) =>
+                if (sym.owner.isTrait) {
+                  reporter.error(tree.pos, "A trait cannot define a native method.")
+                  tree
+                } else if (dd.rhs == EmptyTree) {
+                  // pretend it had a stub implementation
+                  sym resetFlag DEFERRED
+                  deriveDefDef(dd)(_ => typed(gen.mkThrowNewRuntimeException("native method stub")))
+                } else
+                  tree
               case _ => tree
             }