Assign null to self::$_db on reset_db to ensure PDO closes the connections#338
Merged
treffynnon merged 1 commit intoj4mie:developfrom May 30, 2018
Merged
Assign null to self::$_db on reset_db to ensure PDO closes the connections#338treffynnon merged 1 commit intoj4mie:developfrom
treffynnon merged 1 commit intoj4mie:developfrom
Conversation
Collaborator
|
Thank you for the pull request. I'll merge and prepare a release shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered by running
SHOW PROCESSLISTin MySQL that even though I executed\ORM::reset_db()the connections were still hanging and wouldn't be closed until MySQL closed them. This was causingerrno=32 Broken pipeerrors when using Idiorm with a long running script. Even thoughself::$_dbis assigned a new array, not assigningnullseems to make PDO try to reuse old connections, which had been closed by MySQL, causing the aforementionedBroken pipeerror. To make sure PDO closes connections they must be set tonull, from the docs:Setting
self::$_dbtonullbefore assigning a new array ensured that PDO did really close the connection on\ORM::reset_db()and I verified it on MySQL usingSHOW PROCESSLIST, and by the absence of errors in my script.