BG-7981 Fix broken logic on transfers address filtering

Summary: Haste makes waste.

Reviewers: leo, thomas, boris, bigly, tyler

Reviewed By: tyler

Subscribers: tyler

Differential Revision: https://phabricator.bitgo.com/D10051

Author: Jansen McQuivey

src/v2/wallet.js

@@ -207,7 +207,7 @@ Wallet.prototype.transfers = function(params, callback) {
   }
 
   if (params.address) {
-    if (!_.isArray(params.address) || !_.isString) {
+    if (!_.isArray(params.address) && !_.isString(params.address)) {
       throw new Error('invalid address argument, expecting string or array');
     }
     if (_.isArray(params.address)) {

test/v2/unit/wallet.js

@@ -98,6 +98,32 @@ describe('V2 Wallet:', function() {
       scope.isDone().should.be.True();
     }));
 
+    it('should accept a string argument for address', co(function *() {
+      const params = {
+        limit: 1,
+        address: 'stringAddress'
+      };
+
+      const apiParams = {
+        limit: '1',
+        address: 'stringAddress'
+      };
+
+      const scope =
+        nock(bgUrl)
+        .get(`/api/v2/${wallet.coin()}/wallet/${wallet.id()}/transfer`)
+        .query(_.matches(apiParams))
+        .reply(200);
+
+      try {
+        yield wallet.transfers(params);
+      } catch (e) {
+        // test is successful if nock is consumed, HMAC errors expected
+      }
+
+      scope.isDone().should.be.True();
+    }));
+
     it('should throw errors for invalid expected parameters', co(function *() {
       (() => wallet.transfers({ address: 13375 })).should.throw('invalid address argument, expecting string or array');