Skip to content

Commit 4c55ea7

Browse files
blikblumjdalton
authored andcommitted
Use baseGetTag instead of getTag where possible (lodash#4112)
1 parent 7f2ee90 commit 4c55ea7

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

.internal/baseIsEqualDeep.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import Stack from './Stack.js'
22
import equalArrays from './equalArrays.js'
33
import equalByTag from './equalByTag.js'
44
import equalObjects from './equalObjects.js'
5-
import getTag from './getTag.js'
5+
import baseGetTag from './baseGetTag.js'
66
import isBuffer from '../isBuffer.js'
77
import isTypedArray from '../isTypedArray.js'
88

@@ -34,8 +34,8 @@ const hasOwnProperty = Object.prototype.hasOwnProperty
3434
function baseIsEqualDeep(object, other, bitmask, customizer, equalFunc, stack) {
3535
let objIsArr = Array.isArray(object)
3636
const othIsArr = Array.isArray(other)
37-
let objTag = objIsArr ? arrayTag : getTag(object)
38-
let othTag = othIsArr ? arrayTag : getTag(other)
37+
let objTag = objIsArr ? arrayTag : baseGetTag(object)
38+
let othTag = othIsArr ? arrayTag : baseGetTag(other)
3939

4040
objTag = objTag == argsTag ? objectTag : objTag
4141
othTag = othTag == argsTag ? objectTag : othTag

isArguments.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import getTag from './.internal/getTag.js'
1+
import baseGetTag from './.internal/baseGetTag.js'
22
import isObjectLike from './isObjectLike'
33

44
/**
@@ -17,7 +17,7 @@ import isObjectLike from './isObjectLike'
1717
* // => false
1818
*/
1919
function isArguments(value) {
20-
return isObjectLike(value) && getTag(value) == '[object Arguments]'
20+
return isObjectLike(value) && baseGetTag(value) == '[object Arguments]'
2121
}
2222

2323
export default isArguments

isString.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import getTag from './.internal/getTag.js'
1+
import baseGetTag from './.internal/baseGetTag.js'
22

33
/**
44
* Checks if `value` is classified as a `String` primitive or object.
@@ -17,7 +17,7 @@ import getTag from './.internal/getTag.js'
1717
*/
1818
function isString(value) {
1919
const type = typeof value
20-
return type == 'string' || (type == 'object' && value != null && !Array.isArray(value) && getTag(value) == '[object String]')
20+
return type == 'string' || (type == 'object' && value != null && !Array.isArray(value) && baseGetTag(value) == '[object String]')
2121
}
2222

2323
export default isString

isSymbol.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import getTag from './.internal/getTag.js'
1+
import baseGetTag from './.internal/baseGetTag.js'
22

33
/**
44
* Checks if `value` is classified as a `Symbol` primitive or object.
@@ -17,7 +17,7 @@ import getTag from './.internal/getTag.js'
1717
*/
1818
function isSymbol(value) {
1919
const type = typeof value
20-
return type == 'symbol' || (type == 'object' && value != null && getTag(value) == '[object Symbol]')
20+
return type == 'symbol' || (type == 'object' && value != null && baseGetTag(value) == '[object Symbol]')
2121
}
2222

2323
export default isSymbol

isTypedArray.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import getTag from './.internal/getTag.js'
1+
import baseGetTag from './.internal/baseGetTag.js'
22
import nodeTypes from './.internal/nodeTypes.js'
33
import isObjectLike from './isObjectLike'
44

@@ -25,6 +25,6 @@ const nodeIsTypedArray = nodeTypes && nodeTypes.isTypedArray
2525
*/
2626
const isTypedArray = nodeIsTypedArray
2727
? (value) => nodeIsTypedArray(value)
28-
: (value) => isObjectLike(value) && reTypedTag.test(getTag(value))
28+
: (value) => isObjectLike(value) && reTypedTag.test(baseGetTag(value))
2929

3030
export default isTypedArray

0 commit comments

Comments
 (0)