From 0f38bfad67d8b2dc98af3307aa491a90dad823c7 Mon Sep 17 00:00:00 2001 From: Si manglam <90334583+simanglam@users.noreply.github.com> Date: Tue, 3 Dec 2024 21:46:16 +0800 Subject: [PATCH 1/3] fix(convert): Blank web page when converting multiple slides into HTML --- manim_slides/convert.py | 1 + manim_slides/templates/revealjs.html | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/manim_slides/convert.py b/manim_slides/convert.py index b693bc3c..1a50152a 100644 --- a/manim_slides/convert.py +++ b/manim_slides/convert.py @@ -453,6 +453,7 @@ def prefix(i: int) -> str: get_duration_ms=get_duration_ms, has_notes=has_notes, env=os.environ, + prefix=prefix if not self.data_uri else None, **options, ) diff --git a/manim_slides/templates/revealjs.html b/manim_slides/templates/revealjs.html index 33db2c35..14dbf8bb 100644 --- a/manim_slides/templates/revealjs.html +++ b/manim_slides/templates/revealjs.html @@ -25,7 +25,7 @@ {%- if data_uri -%} {% set file = file_to_data_uri(slide_config.file) %} {%- else -%} - {% set file = assets_dir / slide_config.file.name %} + {% set file = assets_dir / (prefix(outer_loop.index0) + slide_config.file.name) %} {%- endif -%}
Date: Wed, 4 Dec 2024 01:34:41 +0800 Subject: [PATCH 2/3] chore(docs): add changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index fc7ae4b6..156bfc5b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -34,6 +34,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 and `av<14`, as their syntax differ, but the former doesn't provide binary wheels for Python 3.9. [#494](https://github.com/jeertmans/manim-slides/pull/494) +- Fixed blank web page when converting multiple slides into HTML [#497](https://github.com/jeertmans/manim-slides/pull/497) (v5.1.9)= ## [v5.1.9](https://github.com/jeertmans/manim-slides/compare/v5.1.8...v5.1.9) From 1fcbca7fb0c1e39ad6e305d244055c8b3ad55644 Mon Sep 17 00:00:00 2001 From: Si manglam <90334583+simanglam@users.noreply.github.com> Date: Wed, 4 Dec 2024 01:37:44 +0800 Subject: [PATCH 3/3] Fix typo --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 156bfc5b..8110b40a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -34,7 +34,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 and `av<14`, as their syntax differ, but the former doesn't provide binary wheels for Python 3.9. [#494](https://github.com/jeertmans/manim-slides/pull/494) -- Fixed blank web page when converting multiple slides into HTML [#497](https://github.com/jeertmans/manim-slides/pull/497) +- Fixed blank web page when converting multiple slides into HTML. + [#497](https://github.com/jeertmans/manim-slides/pull/497) (v5.1.9)= ## [v5.1.9](https://github.com/jeertmans/manim-slides/compare/v5.1.8...v5.1.9)