Skip to content

Exclude users by name from triggering an event as a push event #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
+462 −59
Open

Exclude users by name from triggering an event as a push event #1135

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ca10b85
Exclude user name push events
May 6, 2021
ad3a8dd
Added allusernamesfiltertest
May 6, 2021
ba09140
Modified test cases
May 7, 2021
97a58ab
Modified helpers
May 7, 2021
ae19f16
Modified helpers
May 7, 2021
54ccbd1
Modified helpers
May 7, 2021
f8dce87
sorted imports
May 7, 2021
376a614
Modified readme.md
May 7, 2021
97e3d54
Fixed tests
May 7, 2021
993c514
Validate userName
May 7, 2021
70e68a2
Removed redundant nullcheck of t
May 7, 2021
c43799d
Removed unused getters
May 10, 2021
831d942
Testing visibility properties
May 14, 2021
7368dbb
Merge branch 'master' into master
JCFlores93 May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Testing visibility properties
  • Loading branch information
jean flores committed May 14, 2021
commit 831d94233c8beca915aecc79287c378f16a2e4d1
16 changes: 8 additions & 8 deletions src/main/java/com/dabsquared/gitlabjenkins/GitLabPushTrigger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,13 @@ public class GitLabPushTrigger extends Trigger<Job<?, ?>> implements MergeReques
private transient boolean allowAllUserNames = false;
private transient String branchFilterName;
private BranchFilterType branchFilterType;
private transient String userNameFilterName;
protected final String userNameFilterName;
private UserNameFilterType userNameFilterType;
private String includeBranchesSpec;
private String excludeBranchesSpec;
private String sourceBranchRegex;
private String targetBranchRegex;
private String excludeUserNamesSpec;
protected final String excludeUserNamesSpec;
private MergeRequestLabelFilterConfig mergeRequestLabelFilterConfig;
private volatile Secret secretToken;
private String pendingBuildName;
Expand Down Expand Up @@ -300,9 +300,9 @@ public BranchFilterType getBranchFilterType() {
return branchFilterType;
}

// UserNameFilterType getUserNameFilterType() {
// return userNameFilterType;
// }
public UserNameFilterType getUserNameFilterType() {
return userNameFilterType;
}

public String getIncludeBranchesSpec() {
return includeBranchesSpec;
Expand All @@ -320,9 +320,9 @@ public String getTargetBranchRegex() {
return targetBranchRegex;
}

// String getExcludeUserNamesSpec() {
// return excludeUserNamesSpec;
// }
public String getExcludeUserNamesSpec() {
return excludeUserNamesSpec;
}

public MergeRequestLabelFilterConfig getMergeRequestLabelFilterConfig() {
return mergeRequestLabelFilterConfig;
Expand Down