Skip to content

Commit 228c4ed

Browse files
committed
Remove node nightly tests warning checks
(superseded by TypeStrong#1701)
1 parent be25469 commit 228c4ed

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,8 @@
6969
"build-tsc": "tsc",
7070
"build-configSchema": "typescript-json-schema --topRef --refs --validationKeywords allOf --out tsconfig.schema.json tsconfig.build-schema.json TsConfigSchema && node --require ./register ./scripts/create-merged-schema",
7171
"build-pack": "node ./scripts/build-pack.js",
72-
"test-spec": "ava --node-arguments=--no-deprecation",
73-
"test-cov": "nyc ava --node-arguments=--no-deprecation",
72+
"test-spec": "ava",
73+
"test-cov": "nyc ava",
7474
"test": "npm run build && npm run lint && npm run test-cov --",
7575
"test-local": "npm run lint-fix && npm run build-tsc && npm run build-pack && npm run test-spec --",
7676
"pre-debug": "npm run build-tsc && npm run build-pack",

src/test/esm-loader.spec.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -350,10 +350,7 @@ test.suite('esm', (test) => {
350350
const { err, stdout, stderr } = await cb();
351351
expect(err).toBe(null);
352352
expect(stdout.trim()).toBe('CLI args: foo bar');
353-
// Nightly builds of Node.js might randomly start printing warnings,
354-
// which would cause this test to fail despite actually working,
355-
// so we should ignore stderr when testing on Node.js nightly.
356-
if (!process.version.includes('nightly')) expect(stderr).toBe('');
353+
expect(stderr).toBe('');
357354
});
358355
}
359356

@@ -402,10 +399,7 @@ test.suite('esm', (test) => {
402399
`child registered signal handlers\nchild received signal: ${signal}\nchild exiting`
403400
);
404401
}
405-
// Nightly builds of Node.js might randomly start printing warnings,
406-
// which would cause this test to fail despite actually working,
407-
// so we should ignore stderr when testing on Node.js nightly.
408-
if (!process.version.includes('nightly')) expect(stderr).toBe('');
402+
expect(stderr).toBe('');
409403
});
410404
}
411405
});

0 commit comments

Comments
 (0)