Don't recode ascii only strings

jhy · jhy · commit f0eb6bd1ccce · 2023-10-20T12:08:20.000+11:00
diff --git a/src/main/java/org/jsoup/helper/HttpConnection.java b/src/main/java/org/jsoup/helper/HttpConnection.java
@@ -1145,11 +1145,13 @@ private static boolean looksLikeUtf8(byte[] input) {
             }
 
             int end;
+            boolean foundNonAscii = false;
             for (int j = input.length; i < j; ++i) {
                 int o = input[i];
                 if ((o & 0x80) == 0) {
                     continue; // ASCII
                 }
+                foundNonAscii = true;
 
                 // UTF-8 leading:
                 if ((o & 0xE0) == 0xC0) {
@@ -1173,7 +1175,7 @@ private static boolean looksLikeUtf8(byte[] input) {
                     }
                 }
             }
-            return true;
+            return foundNonAscii;
         }
 
         private @Nullable static String setOutputContentType(final Connection.Request req) {

Original file line number	Diff line number	Diff line change
`@@ -1145,11 +1145,13 @@ private static boolean looksLikeUtf8(byte[] input) {`
`1145`	`1145`	`}`
`1146`	`1146`
`1147`	`1147`	`int end;`
	`1148`	`+ boolean foundNonAscii = false;`
`1148`	`1149`	`for (int j = input.length; i < j; ++i) {`
`1149`	`1150`	`int o = input[i];`
`1150`	`1151`	`if ((o & 0x80) == 0) {`
`1151`	`1152`	`continue; // ASCII`
`1152`	`1153`	`}`
	`1154`	`+ foundNonAscii = true;`
`1153`	`1155`
`1154`	`1156`	`// UTF-8 leading:`
`1155`	`1157`	`if ((o & 0xE0) == 0xC0) {`
`@@ -1173,7 +1175,7 @@ private static boolean looksLikeUtf8(byte[] input) {`
`1173`	`1175`	`}`
`1174`	`1176`	`}`
`1175`	`1177`	`}`
`1176`		`- return true;`
	`1178`	`+ return foundNonAscii;`
`1177`	`1179`	`}`
`1178`	`1180`
`1179`	`1181`	`private @Nullable static String setOutputContentType(final Connection.Request req) {`