Skip to content

Refactored design and implementation smells #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roshni-joshi wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Refactored design and implementation smells #612

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f8ae51b
refactor: Resolved Feature Envy design smell
Nov 21, 2023
00f457d
refactor: Resolved cyclic hierarchy smell, applied push down method r…
Nov 25, 2023
5b05dfe
refactor: Introduced explaining variable
Nov 25, 2023
0d6ba30
refactor: applied decompose conditional refactoring
Nov 26, 2023
c15c1bc
refactor: Renamed variable to more meaningful name
Nov 26, 2023
22d63f0
refactor: Applied extract method refactoring
Nov 26, 2023
7aac7e0
refactor: Applied extract class refactoring to move all generate days…
Nov 27, 2023
4dba1b3
refactor: Added required comments for CronParser
Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: Renamed variable to more meaningful name
  • Loading branch information
Roshni Joshi committed Nov 26, 2023
commit c15c1bcec01cf08a36bd1029bba41121560ada10
6 changes: 3 additions & 3 deletions src/main/java/com/cronutils/parser/CronParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ private Cron validateAndReturnSupportedCronNickname(String nickname, Set<CronNic
*/
public Cron parse(final String expression) {
Preconditions.checkNotNull(expression, "Expression must not be null");
final String replaced = expression.replaceAll("\\s+", " ").trim();
if (StringUtils.isEmpty(replaced)) {
final String noExtraSpaceExpression = expression.replaceAll("\\s+", " ").trim();
if (StringUtils.isEmpty(noExtraSpaceExpression)) {
throw new IllegalArgumentException("Empty expression!");
}

Expand Down Expand Up @@ -143,7 +143,7 @@ public Cron parse(final String expression) {
}
return new CompositeCron(crons.stream().map(this::parse).collect(Collectors.toList()));
}else{
final String[] expressionParts = replaced.toUpperCase().split(" ");
final String[] expressionParts = noExtraSpaceExpression.toUpperCase().split(" ");
final int expressionLength = expressionParts.length;
String fieldWithTrailingCommas = Arrays.stream(expressionParts).filter(x -> x.endsWith(",")).findAny().orElse(null);
if(fieldWithTrailingCommas!=null){
Expand Down