Merge pull request php-webdriver#267 from facebook/gfosco.wait

gfosco · gfosco · commit 518a9e0635e6 · 2015-12-08T09:04:30.000-08:00
Check isset for timeout in seconds
diff --git a/lib/WebDriverWait.php b/lib/WebDriverWait.php
@@ -35,7 +35,7 @@ public function __construct(
       $timeout_in_second = null,
       $interval_in_millisecond = null) {
     $this->driver = $driver;
-    $this->timeout = $timeout_in_second ?: 30;
+    $this->timeout = isset($timeout_in_second) ? $timeout_in_second : 30;
     $this->interval = $interval_in_millisecond ?: 250;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public function __construct(`
`35`	`35`	`$timeout_in_second = null,`
`36`	`36`	`$interval_in_millisecond = null) {`
`37`	`37`	`$this->driver = $driver;`
`38`		`- $this->timeout = $timeout_in_second ?: 30;`
	`38`	`+ $this->timeout = isset($timeout_in_second) ? $timeout_in_second : 30;`
`39`	`39`	`$this->interval = $interval_in_millisecond ?: 250;`
`40`	`40`	`}`
`41`	`41`