chore(transformers): remove reflector parameter from initReflector signature

Remove reflector parameter from initReflector method to simplify ng_deps for reflection
initialization. It wasn't used and was added for testability, but wasn't used. This
keeps the interface simplier.

Author: TedSander

modules/angular2/src/transform/directive_linker/linker.dart

@@ -72,8 +72,7 @@ Future<String> linkNgDeps(AssetReader reader, AssetId entryPoint) async {
       importBuf.write('''
         import '${linkedDepsMap[it.current]}' as i${i};
       ''');
-      declarationBuf
-          .write('i${i}.${SETUP_METHOD_NAME}(${REFLECTOR_VAR_NAME});');
+      declarationBuf.write('i${i}.${SETUP_METHOD_NAME}();');
       ++i;
     }
   }

modules/angular2/src/transform/directive_processor/rewriter.dart

@@ -94,6 +94,7 @@ class CreateNgDepsVisitor extends Object with SimpleAstVisitor<Object> {
     if (_wroteBaseLibImport) return;
     _wroteBaseLibImport = true;
     writer.print('''import '${path.basename(assetId.path)}';''');
+    writer.print("import '$_REFLECTOR_IMPORT' as $_REF_PREFIX;");
   }
 
   void _updateUsesNonLangLibs(UriBasedDirective directive) {
@@ -118,7 +119,7 @@ class CreateNgDepsVisitor extends Object with SimpleAstVisitor<Object> {
   void _openFunctionWrapper() {
     _maybeWriteImport();
     writer.print('var _visited = false;'
-        'void ${SETUP_METHOD_NAME}(${REFLECTOR_VAR_NAME}) {'
+        'void ${SETUP_METHOD_NAME}() {'
         'if (_visited) return; _visited = true;');
   }
 
@@ -256,6 +257,9 @@ class CreateNgDepsVisitor extends Object with SimpleAstVisitor<Object> {
     _foundNgInjectable = true;
 
     // The receiver for cascaded calls.
-    writer.print(REFLECTOR_VAR_NAME);
+    writer.print('$_REF_PREFIX.$REFLECTOR_VAR_NAME');
   }
 }
+
+const _REF_PREFIX = '_ngRef';
+const _REFLECTOR_IMPORT = 'package:angular2/src/reflection/reflection.dart';

modules/angular2/src/transform/reflection_remover/codegen.dart

@@ -53,8 +53,7 @@ class Codegen {
 
     var count = 0;
     return importUris
-        .map((_) =>
-            '${prefix}${count++}.${SETUP_METHOD_NAME}(${reflectorExpression});')
+        .map((_) => '${prefix}${count++}.${SETUP_METHOD_NAME}();')
         .join('');
   }
 }

modules/angular2/test/transform/directive_linker/simple_export_files/bar.ng_deps.dart

@@ -1,14 +1,15 @@
 library bar.ng_deps.dart;
 
 import 'bar.dart';
+import 'package:angular2/src/reflection/reflection.dart' as _ngRef;
 import 'package:angular2/src/core/annotations_impl/annotations.dart';
 export 'foo.dart';
 
 var _visited = false;
-void initReflector(reflector) {
+void initReflector() {
   if (_visited) return;
   _visited = true;
-  reflector
+  _ngRef.reflector
     ..registerType(MyComponent, {
       'factory': () => new MyComponent(),
       'parameters': const [],

modules/angular2/test/transform/directive_linker/simple_export_files/expected/bar.ng_deps.dart

@@ -1,19 +1,20 @@
 library bar.ng_deps.dart;
 
 import 'bar.dart';
+import 'package:angular2/src/reflection/reflection.dart' as _ngRef;
 import 'package:angular2/src/core/annotations_impl/annotations.dart';
 export 'foo.dart';
 import 'foo.ng_deps.dart' as i0;
 
 var _visited = false;
-void initReflector(reflector) {
+void initReflector() {
   if (_visited) return;
   _visited = true;
-  reflector
+  _ngRef.reflector
     ..registerType(MyComponent, {
       'factory': () => new MyComponent(),
       'parameters': const [],
       'annotations': const [const Component(selector: '[soup]')]
     });
-  i0.initReflector(reflector);
+  i0.initReflector();
 }

modules/angular2/test/transform/directive_linker/simple_export_files/expected/foo.ng_deps.dart

@@ -1,13 +1,14 @@
 library foo.ng_deps.dart;
 
 import 'foo.dart';
+import 'package:angular2/src/reflection/reflection.dart' as _ngRef;
 import 'package:angular2/src/core/annotations_impl/annotations.dart';
 
 var _visited = false;
-void initReflector(reflector) {
+void initReflector() {
   if (_visited) return;
   _visited = true;
-  reflector
+  _ngRef.reflector
     ..registerType(DependencyComponent, {
       'factory': () => new DependencyComponent(),
       'parameters': const [],

modules/angular2/test/transform/directive_linker/simple_export_files/expected/index.ng_deps.dart

@@ -1,13 +1,14 @@
 library web_foo.ng_deps.dart;
 
+import 'package:angular2/src/reflection/reflection.dart' as _ngRef;
 import 'package:angular2/src/core/application.dart';
 import 'package:angular2/src/reflection/reflection_capabilities.dart';
 import 'bar.dart';
 import 'bar.ng_deps.dart' as i0;
 
 var _visited = false;
-void initReflector(reflector) {
+void initReflector() {
   if (_visited) return;
   _visited = true;
-  i0.initReflector(reflector);
+  i0.initReflector();
 }

modules/angular2/test/transform/directive_linker/simple_export_files/foo.ng_deps.dart

@@ -1,13 +1,14 @@
 library foo.ng_deps.dart;
 
 import 'foo.dart';
+import 'package:angular2/src/reflection/reflection.dart' as _ngRef;
 import 'package:angular2/src/core/annotations_impl/annotations.dart';
 
 var _visited = false;
-void initReflector(reflector) {
+void initReflector() {
   if (_visited) return;
   _visited = true;
-  reflector
+  _ngRef.reflector
     ..registerType(DependencyComponent, {
       'factory': () => new DependencyComponent(),
       'parameters': const [],

modules/angular2/test/transform/directive_linker/simple_export_files/index.ng_deps.dart

@@ -1,11 +1,12 @@
 library web_foo.ng_deps.dart;
 
+import 'package:angular2/src/reflection/reflection.dart' as _ngRef;
 import 'package:angular2/src/core/application.dart';
 import 'package:angular2/src/reflection/reflection_capabilities.dart';
 import 'bar.dart';
 
 var _visited = false;
-void initReflector(reflector) {
+void initReflector() {
   if (_visited) return;
   _visited = true;
 }

modules/angular2/test/transform/directive_linker/simple_files/bar.ng_deps.dart

@@ -1,14 +1,15 @@
 library bar.ng_deps.dart;
 
 import 'bar.dart';
+import 'package:angular2/src/reflection/reflection.dart' as _ngRef;
 import 'package:angular2/src/core/annotations_impl/annotations.dart';
 import 'foo.dart' as dep;
 
 var _visited = false;
-void initReflector(reflector) {
+void initReflector() {
   if (_visited) return;
   _visited = true;
-  reflector
+  _ngRef.reflector
     ..registerType(MyComponent, {
       'factory': () => new MyComponent(),
       'parameters': const [],