Comparing changes
Open a pull request
- 8 commits
- 7 files changed
- 1 contributor
Commits on Apr 1, 2024
-
Fix NTP client - it would report the wrong time after 7 Feb 2036. Signed-off-by: Jon Foster <[email protected]>
-
-
python-ecosys/requests: Security fix for leaked passwords.
With the old code, if you make a request with HTTP basic auth (a username/password) and did not specify a headers dict, then the cleartext username and password would be added to the default headers to be used for every subsequent HTTP request. That's probably not a good idea. This fixes it so the headers dict passed in, whether default or not, is never changed.
-
python-ecosys/requests: Security: Add a comment documenting a problem.
HTTPS requests made with this module are hideously insecure.
-
python-ecosys/requests: Add User-Agent string.
The HTTP User-Agent string is very useful if malfunctioning IoT devices start putting excessive load on a server. It allows the server operator to ban just the malfunctioning devices, not all users. It's also a SHOULD in the HTTP specification. Add it, enabled by default, but with options to override or disable it.
-
python-ecosys/requests: Make response headers dict lowercase.
The HTTP response headers are case-insensitive. But the old implementation put them in a dictionary keyed by case-sensitive header name. The only way to correctly get a header would have been to iterate through the dictionary looking for it, which is slow and a lot of code and I doubt anyone bothered, I expect that existing code probably just did a case-sensitive match. That's fragile, server changes could break it. To fix that, lowercase all the header names before putting them in the dictionary. That way, clients can just access the dictionary with the lowercase header name and it will do the right thing. This is backward compatible with correctly-written existing code. But it's not compatible with existing code that was buggy anyway and did a case-sensitive match.
-
python-ecosys/requests: Add way to read date-format response headers.
This is intended to make it easy to read the Last-Modified header, but it would work just as well for any of the other date-formatted HTTP response headers.
-
python-stdlib/datetime/datetime.py: Add a TODO.
There's code there that doesn't work properly with timezones. The fix is left for the future, but at least I want to mark it as dodgy to make it more likely I remember to go back and fix it.
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master