Merge branch '4.4'

* 4.4:
  [Twig] Remove dead code
  Minor updates in the new Welcome page
  Add gitignore file for Symfony 4.3
  Add gitignore file for Symfony 3.4
  [Inflector] Add .gitignore file
  [Messenger] Fix exception message of failed message is dropped on retry
  Add default value for Accept header
  [HttpClient] Add .gitignore file
  [Finder] Adjust regex to correctly match comments in gitignore contents
  [Security] Removed unused argument in Test
  [Console] Get dimensions from stty on windows if possible
  [Inflector] add support 'see' to 'ee' for singularize 'fees' to 'fee'

Author: fabpot

Gitignore.php

@@ -25,7 +25,7 @@ class Gitignore
      */
     public static function toRegex(string $gitignoreFileContent): string
     {
-        $gitignoreFileContent = preg_replace('/^[^\\\\]*#.*/', '', $gitignoreFileContent);
+        $gitignoreFileContent = preg_replace('/^[^\\\r\n]*#.*/m', '', $gitignoreFileContent);
         $gitignoreLines = preg_split('/\r\n|\r|\n/', $gitignoreFileContent);
         $gitignoreLines = array_map('trim', $gitignoreLines);
         $gitignoreLines = array_filter($gitignoreLines);

Tests/GitignoreTest.php

@@ -107,7 +107,31 @@ public function provider(): array
                 #IamComment
                 /app/cache/',
                 ['app/cache/file.txt', 'app/cache/subdir/ile.txt'],
-                ['a/app/cache/file.txt'],
+                ['a/app/cache/file.txt', '#IamComment', 'IamComment'],
+            ],
+            [
+                '
+                /app/cache/
+                #LastLineIsComment',
+                ['app/cache/file.txt', 'app/cache/subdir/ile.txt'],
+                ['a/app/cache/file.txt', '#LastLineIsComment', 'LastLineIsComment'],
+            ],
+            [
+                '
+                /app/cache/
+                \#file.txt
+                #LastLineIsComment',
+                ['app/cache/file.txt', 'app/cache/subdir/ile.txt', '#file.txt'],
+                ['a/app/cache/file.txt', '#LastLineIsComment', 'LastLineIsComment'],
+            ],
+            [
+                '
+                /app/cache/
+                \#file.txt
+                #IamComment
+                another_file.txt',
+                ['app/cache/file.txt', 'app/cache/subdir/ile.txt', '#file.txt', 'another_file.txt'],
+                ['a/app/cache/file.txt', 'IamComment', '#IamComment'],
             ],
         ];
     }