Skip to content

Commit b29ed9e

Browse files
jdanbrownstevegury
authored andcommitted
[split] Fix arg type in RetryingFilter.apply
`RetryingFilter.apply` should let its `shouldRetry` argument take a `Try[Nothing]` instead of a `Try[Rep]`, since it's immediately turned into a `RetryPolicy[Try[Nothing]]`. Github-pull-request: twitter#108 Signed-off-by: Steve Gury <[email protected]> RB_ID=86676
1 parent b1dd06a commit b29ed9e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

finagle-core/src/main/scala/com/twitter/finagle/service/RetryingFilter.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ object RetryingFilter {
125125
def apply[Req, Rep](
126126
backoffs: Stream[Duration],
127127
statsReceiver: StatsReceiver = NullStatsReceiver
128-
)(shouldRetry: PartialFunction[Try[Rep], Boolean])(implicit timer: Timer) =
128+
)(shouldRetry: PartialFunction[Try[Nothing], Boolean])(implicit timer: Timer) =
129129
new RetryingFilter[Req, Rep](RetryPolicy.backoff(backoffs)(shouldRetry), timer, statsReceiver)
130130
}
131131

0 commit comments

Comments
 (0)