samesite attribute added

Author: JevinMenezes

.settings/org.eclipse.jdt.apt.core.prefs

@@ -0,0 +1,2 @@
+eclipse.preferences.version=1
+org.eclipse.jdt.apt.aptEnabled=false

.settings/org.eclipse.jdt.core.prefs

@@ -1,8 +1,12 @@
 eclipse.preferences.version=1
 org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
-org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.7
-org.eclipse.jdt.core.compiler.compliance=1.7
+org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.8
+org.eclipse.jdt.core.compiler.compliance=1.8
 org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
+org.eclipse.jdt.core.compiler.problem.enablePreviewFeatures=disabled
 org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
 org.eclipse.jdt.core.compiler.problem.forbiddenReference=warning
-org.eclipse.jdt.core.compiler.source=1.7
+org.eclipse.jdt.core.compiler.problem.reportPreviewFeatures=ignore
+org.eclipse.jdt.core.compiler.processAnnotations=disabled
+org.eclipse.jdt.core.compiler.release=disabled
+org.eclipse.jdt.core.compiler.source=1.8

pom.xml

@@ -13,7 +13,7 @@
     <selenium.version>2.45.0</selenium.version>
     <wildfly.version>20.0.1.Final</wildfly.version>
     <project.scm.id>java-cookie-scm</project.scm.id>
-    <java.home>C:\Program Files\Java\jdk1.8.0_181</java.home>
+    <java.version>1.8</java.version>
   </properties>
   <licenses>
     <license>
@@ -48,8 +48,8 @@
         <artifactId>maven-compiler-plugin</artifactId>
         <version>3.8.1</version>
         <configuration>
-          <source>1.8</source>
-          <target>1.8</target>
+          <source>${java.version}</source>
+          <target>${java.version}</target>
         </configuration>
       </plugin>
       <plugin>
@@ -67,13 +67,6 @@
   </build>
   <dependencyManagement>
     <dependencies>
-      <dependency>
-        <groupId>sun.jdk</groupId>
-        <artifactId>jconsole</artifactId>
-        <version>1.8</version>
-        <scope>system</scope>
-        <systemPath>${java.home}\lib\jconsole.jar</systemPath>
-      </dependency>
       <dependency>
         <groupId>org.jboss.arquillian</groupId>
         <artifactId>arquillian-bom</artifactId>
@@ -177,10 +170,6 @@
         <plugins>
           <plugin>
             <artifactId>maven-dependency-plugin</artifactId>
-            <!--<configuration>
-              <source>1.8</source>
-              <target>1.8</target>
-            </configuration>-->
             <executions>
               <execution>
                 <id>unpack</id>

src/main/java/com/github/jscookie/javacookie/AttributesDefinition.java

@@ -11,4 +11,6 @@ public abstract class AttributesDefinition {
 	abstract Boolean secure();
 	public abstract AttributesDefinition httpOnly( Boolean httpOnly );
 	abstract Boolean httpOnly();
+	public abstract AttributesDefinition sameSite( String sameSite );
+	abstract String sameSite();
 }

src/main/java/com/github/jscookie/javacookie/Cookies.java

@@ -147,6 +147,11 @@ public synchronized void set( String name, String value, AttributesDefinition at
 			header.append( "; HttpOnly" );
 		}
 
+		String sameSite = attributes.sameSite();
+		if ( sameSite != null ) {
+			header.append( "; SameSite=" + sameSite );
+		}
+
 		if ( response.isCommitted() ) {
 			return;
 		}
@@ -416,6 +421,7 @@ public static class Attributes extends AttributesDefinition {
 		private String domain;
 		private Boolean secure;
 		private Boolean httpOnly;
+		private String sameSite;
 
 		private Attributes() {}
 
@@ -473,6 +479,16 @@ public Attributes httpOnly( Boolean httpOnly ) {
 			return this;
 		}
 
+		@Override
+		String sameSite() {
+			return sameSite;
+		}
+		@Override
+		public Attributes sameSite( String sameSite ) {
+			this.sameSite = sameSite;
+			return this;
+		}
+
 		private Attributes merge( AttributesDefinition reference ) {
 			if ( reference.path() != null ) {
 				path = reference.path();
@@ -489,6 +505,9 @@ private Attributes merge( AttributesDefinition reference ) {
 			if ( reference.httpOnly() != null ) {
 				httpOnly = reference.httpOnly();
 			}
+			if ( reference.sameSite() != null ) {
+				domain = reference.sameSite();
+			}
 			return this;
 		}
 	}