Skip to content

Commit f90b02b

Browse files
committed
chore: Swap old usages of 'Roact 17' with 'React Lua'
1 parent 1f5a789 commit f90b02b

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ Projects not in the upstream React repo:
8181
| ------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
8282
| 📌`react-shallow-renderer` | Shallow renderer used in tests for some older React features. Re-exported alongside `react-test-renderer`, source of truth [here](https://github.com/NMinhNguyen/react-shallow-renderer). | ✔️ Ported - with tests that are helping us exercise functionality in the `react` package |
8383
| `react-roblox` | Based on react-dom renderer, shares much of its code and public interface. | Also exports [`act()`](https://github.com/threepointone/react-act-examples/blob/master/sync.md) functionality, which is _required_ for testing components that are asynchronously rendered (the default). |
84-
| `roact-compat` | A comaptibility layer that emulates some deprecated behaviors of legacy Roact | Meant to ease initial adoption of Roact 17, using React APIs directly is encouraged and necessary for newer functonality (eg Hooks) |
84+
| `roact-compat` | A comaptibility layer that emulates some deprecated behaviors of legacy Roact | Meant to ease initial adoption of Roact Lua, using React APIs directly is encouraged and necessary for newer functonality (eg Hooks) |
8585

8686
## Deviations from [Roact](https://github.com/roblox/roact)
8787

modules/react-reconciler/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,4 @@ Debug Tracing is enabled with the enableDebugTracing ReactFeatureFlag. The curre
4141
src/__tests__/ReactSuspenseList-test.js
4242
```
4343

44-
The initial release of Roact 17 includes support for Suspense, but not the unstable SuspenseList API. This was purely to pull in the delivery schedule and narrow the support surface for the initial release.
44+
The initial release of React Lua includes support for Suspense, but not the unstable SuspenseList API. This was purely to pull in the delivery schedule and narrow the support surface for the initial release.

modules/react-roblox/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ Equivalent behavior for `TextBox` would be nice to have, but will need careful i
213213

214214
## Roact.Change and Roact.Event
215215
The Change and Event logic from Roact has been lifted into ReactRoblox. This logic should still behave exactly as it did in Roact. There are a couple things to address:
216-
* This logic needs to be documented as part of Roact 17's deviation documents
216+
* This logic needs to be documented as part of React Lua's deviation documents
217217
* Exposing these as `ReactRoblox.Change` and `ReactRoblox.Event` means that component definitions need to depend upon the ReactRoblox library to provide them
218218
* This leaks the renderer abstraction into component definitions, which could otherwise be renderer-agnostic
219219
* While we don't currently have non-roblox targets, is there a possibility that this abstraction leak causes issues?

modules/roact-compat/src/setGlobalConfig.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ return function(_config)
2020
if _G.__DEV__ and _G.__COMPAT_WARNINGS__ then
2121
warnOnce(
2222
"setGlobalConfig",
23-
"Roact 17 uses a `_G.__DEV__` flag to enable development behavior. "
23+
"React Lua uses a `_G.__DEV__` flag to enable development behavior. "
2424
.. "If you're seeing this warning, you already have it enabled. "
2525
.. "Please remove any redundant uses of `setGlobalConfig`."
2626
)

0 commit comments

Comments
 (0)