Don't call updateInfo during typing.

dragos · dragos · commit 53cd235eacb5 · 2012-09-26T16:35:05.000+02:00
We resort to `setInfo`, basically removing the previous info. This "fixes" a possible race condition
in typing ModuleDefs by making the typer always 'win'. See the assertion stack trace in SI-6429.
diff --git a/src/reflect/scala/reflect/internal/Symbols.scala b/src/reflect/scala/reflect/internal/Symbols.scala
@@ -1469,7 +1469,7 @@ trait Symbols extends api.Symbols { self: SymbolTable =>
     def makeSerializable() {
       info match {
         case ci @ ClassInfoType(_, _, _) =>
-          updateInfo(ci.copy(parents = ci.parents :+ SerializableClass.tpe))
+          setInfo(ci.copy(parents = ci.parents :+ SerializableClass.tpe))
         case i =>
           abort("Only ClassInfoTypes can be made serializable: "+ i)
       }

Original file line number	Diff line number	Diff line change
`@@ -1469,7 +1469,7 @@ trait Symbols extends api.Symbols { self: SymbolTable =>`
`1469`	`1469`	`def makeSerializable() {`
`1470`	`1470`	`info match {`
`1471`	`1471`	`case ci @ ClassInfoType(_, _, _) =>`
`1472`		`- updateInfo(ci.copy(parents = ci.parents :+ SerializableClass.tpe))`
	`1472`	`+ setInfo(ci.copy(parents = ci.parents :+ SerializableClass.tpe))`
`1473`	`1473`	`case i =>`
`1474`	`1474`	`abort("Only ClassInfoTypes can be made serializable: "+ i)`
`1475`	`1475`	`}`