< /div>;',
output: '
;',
- errors: [{message: 'Whitespace is forbidden between `<` and `/`; write `;'
].join('\n'),
output: '
;',
- errors: [{message: 'Whitespace is forbidden between `<` and `/`; write `',
output: '
< /App>',
- errors: [{message: 'Whitespace is required between `<` and `/`; write `< /`'}],
+ errors: [{messageId: 'closeSlashNeedSpace'}],
options: closingSlashOptions('always')
}, {
code: '',
output: '',
- errors: [{message: 'Whitespace is required between `/` and `>`; write `/ >`'}],
+ errors: [{messageId: 'selfCloseSlashNeedSpace'}],
options: closingSlashOptions('always')
}, {
code: '< App/>',
output: '',
- errors: [{message: 'A space is forbidden after opening bracket'}],
+ errors: [{messageId: 'afterOpenNoSpace'}],
options: afterOpeningOptions('never')
}, {
code: '< App>
',
output: '
',
- errors: [{message: 'A space is forbidden after opening bracket'}],
+ errors: [{messageId: 'afterOpenNoSpace'}],
options: afterOpeningOptions('never')
}, {
code: '
',
output: '',
- errors: [{message: 'A space is forbidden after opening bracket'}],
+ errors: [{messageId: 'afterOpenNoSpace'}],
options: afterOpeningOptions('never')
}, {
code: '< App>',
output: '',
errors: [
- {message: 'A space is forbidden after opening bracket'},
- {message: 'A space is forbidden after opening bracket'}
+ {messageId: 'afterOpenNoSpace'},
+ {messageId: 'afterOpenNoSpace'}
],
options: afterOpeningOptions('never')
}, {
@@ -330,45 +330,45 @@ ruleTester.run('jsx-tag-spacing', rule, {
'App/>'
].join('\n'),
output: '',
- errors: [{message: 'A space is forbidden after opening bracket'}],
+ errors: [{messageId: 'afterOpenNoSpace'}],
options: afterOpeningOptions('never')
}, {
code: '',
output: '< App>',
- errors: [{message: 'A space is required after opening bracket'}],
+ errors: [{messageId: 'afterOpenNeedSpace'}],
options: afterOpeningOptions('always')
}, {
code: '< App>',
output: '< App>',
- errors: [{message: 'A space is required after opening bracket'}],
+ errors: [{messageId: 'afterOpenNeedSpace'}],
options: afterOpeningOptions('always')
}, {
code: '',
output: '< App>',
errors: [
- {message: 'A space is required after opening bracket'},
- {message: 'A space is required after opening bracket'}
+ {messageId: 'afterOpenNeedSpace'},
+ {messageId: 'afterOpenNeedSpace'}
],
options: afterOpeningOptions('always')
}, {
code: '',
output: '< App/>',
- errors: [{message: 'A space is required after opening bracket'}],
+ errors: [{messageId: 'afterOpenNeedSpace'}],
options: afterOpeningOptions('always')
}, {
code: '< App/>',
output: '',
- errors: [{message: 'A space is forbidden after opening bracket'}],
+ errors: [{messageId: 'afterOpenNoSpace'}],
options: afterOpeningOptions('allow-multiline')
}, {
code: '',
output: '',
- errors: [{message: 'A space is forbidden before closing bracket'}],
+ errors: [{messageId: 'beforeCloseNoSpace'}],
options: beforeClosingOptions('never')
}, {
code: '',
output: '',
- errors: [{message: 'A space is forbidden before closing bracket'}],
+ errors: [{messageId: 'beforeCloseNoSpace'}],
options: beforeClosingOptions('never')
}, {
code: [
@@ -383,17 +383,17 @@ ruleTester.run('jsx-tag-spacing', rule, {
'>',
''
].join('\n'),
- errors: [{message: 'A space is forbidden before closing bracket'}],
+ errors: [{messageId: 'beforeCloseNoSpace'}],
options: beforeClosingOptions('never')
}, {
code: '
',
output: '
',
- errors: [{message: 'Whitespace is required before closing bracket'}],
+ errors: [{messageId: 'beforeCloseNeedSpace'}],
options: beforeClosingOptions('always')
}, {
code: '
',
output: '
',
- errors: [{message: 'Whitespace is required before closing bracket'}],
+ errors: [{messageId: 'beforeCloseNeedSpace'}],
options: beforeClosingOptions('always')
}, {
code: [
@@ -408,7 +408,7 @@ ruleTester.run('jsx-tag-spacing', rule, {
'>',
''
].join('\n'),
- errors: [{message: 'Whitespace is required before closing bracket'}],
+ errors: [{messageId: 'beforeCloseNeedSpace'}],
options: beforeClosingOptions('always')
}]
});
diff --git a/tests/lib/rules/jsx-wrap-multilines.js b/tests/lib/rules/jsx-wrap-multilines.js
index b653b8f391..aebf742158 100644
--- a/tests/lib/rules/jsx-wrap-multilines.js
+++ b/tests/lib/rules/jsx-wrap-multilines.js
@@ -26,9 +26,6 @@ const parserOptions = {
// Constants/Code Snippets
// ------------------------------------------------------------------------------
-const MISSING_PARENS = 'Missing parentheses around multilines JSX';
-const PARENS_NEW_LINES = 'Parentheses around JSX should be on separate lines';
-
const OPTIONS_ALL_NEW_LINES = {
declaration: 'parens-new-line',
assignment: 'parens-new-line',
@@ -844,45 +841,45 @@ ruleTester.run('jsx-wrap-multilines', rule, {
{
code: RETURN_NO_PAREN,
output: RETURN_PAREN,
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: RETURN_NO_PAREN_FRAGMENT,
parser: parsers.BABEL_ESLINT,
output: RETURN_PAREN_FRAGMENT,
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: RETURN_NO_PAREN,
output: RETURN_PAREN,
options: [{return: true}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: RETURN_NO_PAREN_FRAGMENT,
parser: parsers.BABEL_ESLINT,
output: RETURN_PAREN_FRAGMENT,
options: [{return: true}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: DECLARATION_TERNARY_NO_PAREN,
output: DECLARATION_TERNARY_PAREN,
errors: [
- {message: MISSING_PARENS},
- {message: MISSING_PARENS}
+ {messageId: 'missingParens'},
+ {messageId: 'missingParens'}
]
}, {
code: DECLARATION_TERNARY_NO_PAREN_FRAGMENT,
parser: parsers.BABEL_ESLINT,
output: DECLARATION_TERNARY_PAREN_FRAGMENT,
errors: [
- {message: MISSING_PARENS},
- {message: MISSING_PARENS}
+ {messageId: 'missingParens'},
+ {messageId: 'missingParens'}
]
}, {
code: DECLARATION_TERNARY_NO_PAREN,
output: DECLARATION_TERNARY_PAREN,
options: [{declaration: true}],
errors: [
- {message: MISSING_PARENS},
- {message: MISSING_PARENS}
+ {messageId: 'missingParens'},
+ {messageId: 'missingParens'}
]
}, {
code: DECLARATION_TERNARY_NO_PAREN_FRAGMENT,
@@ -890,31 +887,31 @@ ruleTester.run('jsx-wrap-multilines', rule, {
output: DECLARATION_TERNARY_PAREN_FRAGMENT,
options: [{declaration: true}],
errors: [
- {message: MISSING_PARENS},
- {message: MISSING_PARENS}
+ {messageId: 'missingParens'},
+ {messageId: 'missingParens'}
]
}, {
code: ASSIGNMENT_TERNARY_NO_PAREN,
output: ASSIGNMENT_TERNARY_PAREN,
errors: [
- {message: MISSING_PARENS},
- {message: MISSING_PARENS}
+ {messageId: 'missingParens'},
+ {messageId: 'missingParens'}
]
}, {
code: ASSIGNMENT_TERNARY_NO_PAREN_FRAGMENT,
parser: parsers.BABEL_ESLINT,
output: ASSIGNMENT_TERNARY_PAREN_FRAGMENT,
errors: [
- {message: MISSING_PARENS},
- {message: MISSING_PARENS}
+ {messageId: 'missingParens'},
+ {messageId: 'missingParens'}
]
}, {
code: ASSIGNMENT_TERNARY_NO_PAREN,
output: ASSIGNMENT_TERNARY_PAREN,
options: [{assignment: true}],
errors: [
- {message: MISSING_PARENS},
- {message: MISSING_PARENS}
+ {messageId: 'missingParens'},
+ {messageId: 'missingParens'}
]
}, {
code: ASSIGNMENT_TERNARY_NO_PAREN_FRAGMENT,
@@ -922,138 +919,138 @@ ruleTester.run('jsx-wrap-multilines', rule, {
output: ASSIGNMENT_TERNARY_PAREN_FRAGMENT,
options: [{assignment: true}],
errors: [
- {message: MISSING_PARENS},
- {message: MISSING_PARENS}
+ {messageId: 'missingParens'},
+ {messageId: 'missingParens'}
]
}, {
code: DECLARATION_NO_PAREN,
output: DECLARATION_PAREN,
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: DECLARATION_NO_PAREN_FRAGMENT,
parser: parsers.BABEL_ESLINT,
output: DECLARATION_PAREN_FRAGMENT,
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: DECLARATION_NO_PAREN,
output: DECLARATION_PAREN,
options: [{declaration: true}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: ASSIGNMENT_NO_PAREN,
output: ASSIGNMENT_PAREN,
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: ASSIGNMENT_NO_PAREN_FRAGMENT,
parser: parsers.BABEL_ESLINT,
output: ASSIGNMENT_PAREN_FRAGMENT,
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: ASSIGNMENT_NO_PAREN,
output: ASSIGNMENT_PAREN,
options: [{assignment: true}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: ARROW_NO_PAREN,
output: ARROW_PAREN,
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: ARROW_NO_PAREN_FRAGMENT,
parser: parsers.BABEL_ESLINT,
output: ARROW_PAREN_FRAGMENT,
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: ARROW_NO_PAREN,
output: ARROW_PAREN,
options: [{arrow: true}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: CONDITION_NO_PAREN,
output: CONDITION_PAREN,
options: [{condition: 'parens'}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: CONDITION_NO_PAREN_FRAGMENT,
parser: parsers.BABEL_ESLINT,
output: CONDITION_PAREN_FRAGMENT,
options: [{condition: 'parens'}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: CONDITION_NO_PAREN,
output: CONDITION_PAREN,
options: [{condition: true}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: LOGICAL_NO_PAREN,
output: LOGICAL_PAREN,
options: [{logical: 'parens'}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: LOGICAL_NO_PAREN_FRAGMENT,
parser: parsers.BABEL_ESLINT,
output: LOGICAL_PAREN_FRAGMENT,
options: [{logical: 'parens'}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: LOGICAL_NO_PAREN,
output: LOGICAL_PAREN,
options: [{logical: true}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: ATTR_NO_PAREN,
output: ATTR_PAREN,
options: [{prop: 'parens'}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: ATTR_NO_PAREN_FRAGMENT,
parser: parsers.BABEL_ESLINT,
output: ATTR_PAREN_FRAGMENT,
options: [{prop: 'parens'}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: ATTR_NO_PAREN,
output: ATTR_PAREN,
options: [{prop: true}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: RETURN_NO_PAREN,
output: addNewLineSymbols(RETURN_PAREN),
options: [{return: 'parens-new-line'}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: RETURN_NO_PAREN_FRAGMENT,
parser: parsers.BABEL_ESLINT,
output: addNewLineSymbols(RETURN_PAREN_FRAGMENT),
options: [{return: 'parens-new-line'}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: RETURN_PAREN,
output: addNewLineSymbols(RETURN_PAREN),
options: [{return: 'parens-new-line'}],
- errors: [{message: PARENS_NEW_LINES}]
+ errors: [{messageId: 'parensOnNewLines'}]
}, {
code: RETURN_PAREN_NEW_LINE_OPENING,
output: RETURN_PAREN_NEW_LINE_OPENING_FIXED,
options: [{return: 'parens-new-line'}],
- errors: [{message: PARENS_NEW_LINES}]
+ errors: [{messageId: 'parensOnNewLines'}]
}, {
code: RETURN_PAREN_NEW_LINE_CLOSING,
output: RETURN_PAREN_NEW_LINE_CLOSING_FIXED,
options: [{return: 'parens-new-line'}],
- errors: [{message: PARENS_NEW_LINES}]
+ errors: [{messageId: 'parensOnNewLines'}]
}, {
code: RETURN_PAREN_FRAGMENT,
parser: parsers.BABEL_ESLINT,
output: addNewLineSymbols(RETURN_PAREN_FRAGMENT),
options: [{return: 'parens-new-line'}],
- errors: [{message: PARENS_NEW_LINES}]
+ errors: [{messageId: 'parensOnNewLines'}]
}, {
code: DECLARATION_TERNARY_NO_PAREN,
output: addNewLineSymbols(DECLARATION_TERNARY_PAREN),
options: [{declaration: 'parens-new-line'}],
errors: [
- {message: MISSING_PARENS},
- {message: MISSING_PARENS}
+ {messageId: 'missingParens'},
+ {messageId: 'missingParens'}
]
}, {
code: DECLARATION_TERNARY_NO_PAREN_FRAGMENT,
@@ -1061,8 +1058,8 @@ ruleTester.run('jsx-wrap-multilines', rule, {
output: addNewLineSymbols(DECLARATION_TERNARY_PAREN_FRAGMENT),
options: [{declaration: 'parens-new-line'}],
errors: [
- {message: MISSING_PARENS},
- {message: MISSING_PARENS}
+ {messageId: 'missingParens'},
+ {messageId: 'missingParens'}
]
}, {
code: DECLARATION_TERNARY_PAREN_FRAGMENT,
@@ -1070,16 +1067,16 @@ ruleTester.run('jsx-wrap-multilines', rule, {
output: addNewLineSymbols(DECLARATION_TERNARY_PAREN_FRAGMENT),
options: [{declaration: 'parens-new-line'}],
errors: [
- {message: PARENS_NEW_LINES},
- {message: PARENS_NEW_LINES}
+ {messageId: 'parensOnNewLines'},
+ {messageId: 'parensOnNewLines'}
]
}, {
code: DECLARATION_TERNARY_PAREN,
output: addNewLineSymbols(DECLARATION_TERNARY_PAREN),
options: [{declaration: 'parens-new-line'}],
errors: [
- {message: PARENS_NEW_LINES},
- {message: PARENS_NEW_LINES}
+ {messageId: 'parensOnNewLines'},
+ {messageId: 'parensOnNewLines'}
]
}, {
code: DECLARATION_TERNARY_PAREN_FRAGMENT,
@@ -1087,16 +1084,16 @@ ruleTester.run('jsx-wrap-multilines', rule, {
output: addNewLineSymbols(DECLARATION_TERNARY_PAREN_FRAGMENT),
options: [{declaration: 'parens-new-line'}],
errors: [
- {message: PARENS_NEW_LINES},
- {message: PARENS_NEW_LINES}
+ {messageId: 'parensOnNewLines'},
+ {messageId: 'parensOnNewLines'}
]
}, {
code: ASSIGNMENT_TERNARY_NO_PAREN,
output: addNewLineSymbols(ASSIGNMENT_TERNARY_PAREN),
options: [{assignment: 'parens-new-line'}],
errors: [
- {message: MISSING_PARENS},
- {message: MISSING_PARENS}
+ {messageId: 'missingParens'},
+ {messageId: 'missingParens'}
]
}, {
code: ASSIGNMENT_TERNARY_NO_PAREN_FRAGMENT,
@@ -1104,16 +1101,16 @@ ruleTester.run('jsx-wrap-multilines', rule, {
output: addNewLineSymbols(ASSIGNMENT_TERNARY_PAREN_FRAGMENT),
options: [{assignment: 'parens-new-line'}],
errors: [
- {message: MISSING_PARENS},
- {message: MISSING_PARENS}
+ {messageId: 'missingParens'},
+ {messageId: 'missingParens'}
]
}, {
code: ASSIGNMENT_TERNARY_PAREN,
output: addNewLineSymbols(ASSIGNMENT_TERNARY_PAREN),
options: [{assignment: 'parens-new-line'}],
errors: [
- {message: PARENS_NEW_LINES},
- {message: PARENS_NEW_LINES}
+ {messageId: 'parensOnNewLines'},
+ {messageId: 'parensOnNewLines'}
]
}, {
code: ASSIGNMENT_TERNARY_PAREN_FRAGMENT,
@@ -1121,117 +1118,117 @@ ruleTester.run('jsx-wrap-multilines', rule, {
output: addNewLineSymbols(ASSIGNMENT_TERNARY_PAREN_FRAGMENT),
options: [{assignment: 'parens-new-line'}],
errors: [
- {message: PARENS_NEW_LINES},
- {message: PARENS_NEW_LINES}
+ {messageId: 'parensOnNewLines'},
+ {messageId: 'parensOnNewLines'}
]
}, {
code: DECLARATION_NO_PAREN,
output: addNewLineSymbols(DECLARATION_PAREN),
options: [{declaration: 'parens-new-line'}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: DECLARATION_PAREN,
output: addNewLineSymbols(DECLARATION_PAREN),
options: [{declaration: 'parens-new-line'}],
- errors: [{message: PARENS_NEW_LINES}]
+ errors: [{messageId: 'parensOnNewLines'}]
}, {
code: ASSIGNMENT_NO_PAREN,
output: addNewLineSymbols(ASSIGNMENT_PAREN),
options: [{assignment: 'parens-new-line'}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: ASSIGNMENT_PAREN,
output: addNewLineSymbols(ASSIGNMENT_PAREN),
options: [{assignment: 'parens-new-line'}],
- errors: [{message: PARENS_NEW_LINES}]
+ errors: [{messageId: 'parensOnNewLines'}]
}, {
code: ARROW_PAREN,
output: addNewLineSymbols(ARROW_PAREN),
options: [{arrow: 'parens-new-line'}],
- errors: [{message: PARENS_NEW_LINES}]
+ errors: [{messageId: 'parensOnNewLines'}]
}, {
code: ARROW_PAREN_FRAGMENT,
parser: parsers.BABEL_ESLINT,
output: addNewLineSymbols(ARROW_PAREN_FRAGMENT),
options: [{arrow: 'parens-new-line'}],
- errors: [{message: PARENS_NEW_LINES}]
+ errors: [{messageId: 'parensOnNewLines'}]
}, {
code: ARROW_NO_PAREN,
output: addNewLineSymbols(ARROW_PAREN),
options: [{arrow: 'parens-new-line'}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: ARROW_NO_PAREN_FRAGMENT,
parser: parsers.BABEL_ESLINT,
output: addNewLineSymbols(ARROW_PAREN_FRAGMENT),
options: [{arrow: 'parens-new-line'}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: CONDITION_PAREN,
output: addNewLineSymbols(CONDITION_PAREN),
options: [{condition: 'parens-new-line'}],
- errors: [{message: PARENS_NEW_LINES}]
+ errors: [{messageId: 'parensOnNewLines'}]
}, {
code: CONDITION_PAREN_FRAGMENT,
parser: parsers.BABEL_ESLINT,
output: addNewLineSymbols(CONDITION_PAREN_FRAGMENT),
options: [{condition: 'parens-new-line'}],
- errors: [{message: PARENS_NEW_LINES}]
+ errors: [{messageId: 'parensOnNewLines'}]
}, {
code: CONDITION_NO_PAREN,
output: addNewLineSymbols(CONDITION_PAREN),
options: [{condition: 'parens-new-line'}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: CONDITION_NO_PAREN_FRAGMENT,
parser: parsers.BABEL_ESLINT,
output: addNewLineSymbols(CONDITION_PAREN_FRAGMENT),
options: [{condition: 'parens-new-line'}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: LOGICAL_PAREN,
output: addNewLineSymbols(LOGICAL_PAREN),
options: [{logical: 'parens-new-line'}],
- errors: [{message: PARENS_NEW_LINES}]
+ errors: [{messageId: 'parensOnNewLines'}]
}, {
code: LOGICAL_NO_PAREN,
output: LOGICAL_PAREN_NEW_LINE_AUTOFIX,
options: [{logical: 'parens-new-line'}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: LOGICAL_NO_PAREN_FRAGMENT,
parser: parsers.BABEL_ESLINT,
output: LOGICAL_PAREN_NEW_LINE_AUTOFIX_FRAGMENT,
options: [{logical: 'parens-new-line'}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: ATTR_PAREN,
output: addNewLineSymbols(ATTR_PAREN),
options: [{prop: 'parens-new-line'}],
- errors: [{message: PARENS_NEW_LINES}]
+ errors: [{messageId: 'parensOnNewLines'}]
}, {
code: ATTR_PAREN_FRAGMENT,
parser: parsers.BABEL_ESLINT,
output: addNewLineSymbols(ATTR_PAREN_FRAGMENT),
options: [{prop: 'parens-new-line'}],
- errors: [{message: PARENS_NEW_LINES}]
+ errors: [{messageId: 'parensOnNewLines'}]
}, {
code: ATTR_NO_PAREN,
output: ATTR_PAREN_NEW_LINE_AUTOFIX,
options: [{prop: 'parens-new-line'}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: ATTR_NO_PAREN_FRAGMENT,
parser: parsers.BABEL_ESLINT,
output: ATTR_PAREN_NEW_LINE_AUTOFIX_FRAGMENT,
options: [{prop: 'parens-new-line'}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
},
{
code: SFC_NO_PARENS_NO_NEWLINE,
output: SFC_NO_PARENS_AUTOFIX,
options: [OPTIONS_ALL_NEW_LINES],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: ARROW_WITH_EXPORT,
output: ARROW_WITH_EXPORT_AUTOFIX,
@@ -1244,12 +1241,12 @@ ruleTester.run('jsx-wrap-multilines', rule, {
logical: 'ignore',
prop: 'ignore'
}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: ARROW_WITH_LOGICAL,
output: ARROW_WITH_LOGICAL_AUTOFIX,
options: [{logical: 'parens-new-line'}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}, {
code: [
'import React from \'react\';',
@@ -1269,6 +1266,6 @@ ruleTester.run('jsx-wrap-multilines', rule, {
');'
].join('\n'),
options: [{declaration: 'parens-new-line'}],
- errors: [{message: MISSING_PARENS}]
+ errors: [{messageId: 'missingParens'}]
}]
});
diff --git a/tests/lib/rules/no-access-state-in-setstate.js b/tests/lib/rules/no-access-state-in-setstate.js
index b5e215b0e3..ff621ddb5c 100644
--- a/tests/lib/rules/no-access-state-in-setstate.js
+++ b/tests/lib/rules/no-access-state-in-setstate.js
@@ -148,9 +148,7 @@ ruleTester.run('no-access-state-in-setstate', rule, {
'});'
].join('\n'),
parserOptions,
- errors: [{
- message: 'Use callback in setState when referencing the previous state.'
- }]
+ errors: [{messageId: 'useCallback'}]
}, {
code: [
'var Hello = React.createClass({',
@@ -160,9 +158,7 @@ ruleTester.run('no-access-state-in-setstate', rule, {
'});'
].join('\n'),
parserOptions,
- errors: [{
- message: 'Use callback in setState when referencing the previous state.'
- }]
+ errors: [{messageId: 'useCallback'}]
}, {
code: [
'var Hello = React.createClass({',
@@ -173,9 +169,7 @@ ruleTester.run('no-access-state-in-setstate', rule, {
'});'
].join('\n'),
parserOptions,
- errors: [{
- message: 'Use callback in setState when referencing the previous state.'
- }]
+ errors: [{messageId: 'useCallback'}]
}, {
code: [
'var Hello = React.createClass({',
@@ -186,9 +180,7 @@ ruleTester.run('no-access-state-in-setstate', rule, {
'});'
].join('\n'),
parserOptions,
- errors: [{
- message: 'Use callback in setState when referencing the previous state.'
- }]
+ errors: [{messageId: 'useCallback'}]
}, {
code: [
'function nextState(state) {',
@@ -201,9 +193,7 @@ ruleTester.run('no-access-state-in-setstate', rule, {
'});'
].join('\n'),
parserOptions,
- errors: [{
- message: 'Use callback in setState when referencing the previous state.'
- }]
+ errors: [{messageId: 'useCallback'}]
}, {
code: `
var Hello = React.createClass({
@@ -213,9 +203,7 @@ ruleTester.run('no-access-state-in-setstate', rule, {
});
`,
parserOptions,
- errors: [{
- message: 'Use callback in setState when referencing the previous state.'
- }]
+ errors: [{messageId: 'useCallback'}]
}, {
code: `
var Hello = React.createClass({
@@ -225,9 +213,7 @@ ruleTester.run('no-access-state-in-setstate', rule, {
});
`,
parserOptions,
- errors: [{
- message: 'Use callback in setState when referencing the previous state.'
- }]
+ errors: [{messageId: 'useCallback'}]
}, {
code: [
'var Hello = React.createClass({',
@@ -240,9 +226,7 @@ ruleTester.run('no-access-state-in-setstate', rule, {
'});'
].join('\n'),
parserOptions,
- errors: [{
- message: 'Use callback in setState when referencing the previous state.'
- }]
+ errors: [{messageId: 'useCallback'}]
}, {
code: `
class Hello extends React.Component {
@@ -252,8 +236,6 @@ ruleTester.run('no-access-state-in-setstate', rule, {
}
`,
parserOptions,
- errors: [{
- message: 'Use callback in setState when referencing the previous state.'
- }]
+ errors: [{messageId: 'useCallback'}]
}]
});
diff --git a/tests/lib/rules/no-adjacent-inline-elements.js b/tests/lib/rules/no-adjacent-inline-elements.js
index 1c2e9becc4..bcaef193ad 100644
--- a/tests/lib/rules/no-adjacent-inline-elements.js
+++ b/tests/lib/rules/no-adjacent-inline-elements.js
@@ -12,8 +12,6 @@
const RuleTester = require('eslint').RuleTester;
const rule = require('../../../lib/rules/no-adjacent-inline-elements');
-const ERROR = rule.ERROR;
-
const parserOptions = {
ecmaVersion: 6,
ecmaFeatures: {
@@ -90,17 +88,17 @@ ruleTester.run('no-adjacent-inline-elements', rule, {
invalid: [
{
code: '
;',
- errors: [{message: ERROR}],
+ errors: [{messageId: 'inlineElement'}],
parserOptions
},
{
code: '
;',
- errors: [{message: ERROR}],
+ errors: [{messageId: 'inlineElement'}],
parserOptions
},
{
code: 'React.createElement("div", undefined, [React.createElement("a"), React.createElement("span")]);',
- errors: [{message: ERROR}],
+ errors: [{messageId: 'inlineElement'}],
parserOptions
}
]
diff --git a/tests/lib/rules/no-array-index-key.js b/tests/lib/rules/no-array-index-key.js
index ec4370298c..9dc47c0a6c 100644
--- a/tests/lib/rules/no-array-index-key.js
+++ b/tests/lib/rules/no-array-index-key.js
@@ -10,6 +10,7 @@
// -----------------------------------------------------------------------------
const RuleTester = require('eslint').RuleTester;
+const parsers = require('../../helpers/parsers');
const rule = require('../../../lib/rules/no-array-index-key');
const parserOptions = {
@@ -26,7 +27,7 @@ const parserOptions = {
const ruleTester = new RuleTester({parserOptions});
ruleTester.run('no-array-index-key', rule, {
- valid: [
+ valid: [].concat(
{code: '
;'},
{code: '
;'},
{code: '
;'},
@@ -105,43 +106,59 @@ ruleTester.run('no-array-index-key', rule, {
return React.cloneElement(child, { key: child.id });
})
`
- }
- ],
+ },
- invalid: [
+ parsers.ES2020({
+ code: 'foo?.map(child =>
)',
+ parserOptions: {
+ ecmaVersion: 2020
+ }
+ }, {
+ code: 'foo?.map(child =>
)',
+ parser: parsers.BABEL_ESLINT
+ }, {
+ code: 'foo?.map(child =>
)',
+ parser: parsers.TYPESCRIPT_ESLINT
+ }, {
+ code: 'foo?.map(child =>
)',
+ parser: parsers['@TYPESCRIPT_ESLINT']
+ })
+ ),
+
+ invalid: [].concat(
{
code: 'foo.map((bar, i) =>
)',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: '[{}, {}].map((bar, i) =>
)',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.map((bar, anything) =>
)',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.map((bar, i) =>
)',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.map((bar, i) =>
)',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.map((bar, i) =>
)',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.map((baz, i) => React.cloneElement(someChild, { ...someChild.props, key: i }))',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
@@ -152,97 +169,97 @@ ruleTester.run('no-array-index-key', rule, {
})
})
`,
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.forEach((bar, i) => { baz.push(
); })',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.filter((bar, i) => { baz.push(
); })',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.some((bar, i) => { baz.push(
); })',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.every((bar, i) => { baz.push(
); })',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.find((bar, i) => { baz.push(
); })',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.findIndex((bar, i) => { baz.push(
); })',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.reduce((a, b, i) => a.concat(
), [])',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.reduceRight((a, b, i) => a.concat(
), [])',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.map((bar, i) => React.createElement(\'Foo\', { key: i }))',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.map((bar, i) => React.createElement(\'Foo\', { key: `foo-${i}` }))',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.map((bar, i) => React.createElement(\'Foo\', { key: \'foo-\' + i }))',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.map((bar, i) => React.createElement(\'Foo\', { key: \'foo-\' + i + \'-bar\' }))',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.forEach((bar, i) => { baz.push(React.createElement(\'Foo\', { key: i })); })',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.filter((bar, i) => { baz.push(React.createElement(\'Foo\', { key: i })); })',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.some((bar, i) => { baz.push(React.createElement(\'Foo\', { key: i })); })',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.every((bar, i) => { baz.push(React.createElement(\'Foo\', { key: i })); })',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.find((bar, i) => { baz.push(React.createElement(\'Foo\', { key: i })); })',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
code: 'foo.findIndex((bar, i) => { baz.push(React.createElement(\'Foo\', { key: i })); })',
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
@@ -251,7 +268,7 @@ ruleTester.run('no-array-index-key', rule, {
return React.cloneElement(child, { key: index });
})
`,
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
@@ -260,7 +277,7 @@ ruleTester.run('no-array-index-key', rule, {
return React.cloneElement(child, { key: index });
})
`,
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
@@ -269,7 +286,7 @@ ruleTester.run('no-array-index-key', rule, {
return React.cloneElement(child, { key: index });
})
`,
- errors: [{message: 'Do not use Array index in keys'}]
+ errors: [{messageId: 'noArrayIndex'}]
},
{
@@ -278,8 +295,27 @@ ruleTester.run('no-array-index-key', rule, {
return React.cloneElement(child, { key: index });
})
`,
- errors: [{message: 'Do not use Array index in keys'}]
- }
-
- ]
+ errors: [{messageId: 'noArrayIndex'}]
+ },
+
+ parsers.ES2020({
+ code: 'foo?.map((child, i) =>
)',
+ errors: [{messageId: 'noArrayIndex'}],
+ parserOptions: {
+ ecmaVersion: 2020
+ }
+ }, {
+ code: 'foo?.map((child, i) =>
)',
+ errors: [{messageId: 'noArrayIndex'}],
+ parser: parsers.BABEL_ESLINT
+ }, {
+ code: 'foo?.map((child, i) =>
)',
+ errors: [{messageId: 'noArrayIndex'}],
+ parser: parsers.TYPESCRIPT_ESLINT
+ }, {
+ code: 'foo?.map((child, i) =>
)',
+ errors: [{messageId: 'noArrayIndex'}],
+ parser: parsers['@TYPESCRIPT_ESLINT']
+ })
+ )
});
diff --git a/tests/lib/rules/no-children-prop.js b/tests/lib/rules/no-children-prop.js
index 38ac009819..63bf3366d6 100644
--- a/tests/lib/rules/no-children-prop.js
+++ b/tests/lib/rules/no-children-prop.js
@@ -20,9 +20,6 @@ const parserOptions = {
}
};
-const JSX_ERROR = 'Do not pass children as props. Instead, nest children between the opening and closing tags.';
-const CREATE_ELEMENT_ERROR = 'Do not pass children as props. Instead, pass them as additional arguments to React.createElement.';
-
// -----------------------------------------------------------------------------
// Tests
// -----------------------------------------------------------------------------
@@ -145,59 +142,59 @@ ruleTester.run('no-children-prop', rule, {
invalid: [
{
code: '
;',
- errors: [{message: JSX_ERROR}]
+ errors: [{messageId: 'nestChildren'}]
},
{
code: '
} />;',
- errors: [{message: JSX_ERROR}]
+ errors: [{messageId: 'nestChildren'}]
},
{
code: '
,
]} />;',
- errors: [{message: JSX_ERROR}]
+ errors: [{messageId: 'nestChildren'}]
},
{
code: '
Children
;',
- errors: [{message: JSX_ERROR}]
+ errors: [{messageId: 'nestChildren'}]
},
{
code: 'React.createElement("div", {children: "Children"});',
- errors: [{message: CREATE_ELEMENT_ERROR}]
+ errors: [{messageId: 'passChildrenAsArgs'}]
},
{
code: 'React.createElement("div", {children: "Children"}, "Children");',
- errors: [{message: CREATE_ELEMENT_ERROR}]
+ errors: [{messageId: 'passChildrenAsArgs'}]
},
{
code: 'React.createElement("div", {children: React.createElement("div")});',
- errors: [{message: CREATE_ELEMENT_ERROR}]
+ errors: [{messageId: 'passChildrenAsArgs'}]
},
{
code: 'React.createElement("div", {children: [React.createElement("div"), React.createElement("div")]});',
- errors: [{message: CREATE_ELEMENT_ERROR}]
+ errors: [{messageId: 'passChildrenAsArgs'}]
},
{
code: '
',
- errors: [{message: JSX_ERROR}]
+ errors: [{messageId: 'nestChildren'}]
},
{
code: 'React.createElement(MyComponent, {children: "Children"});',
- errors: [{message: CREATE_ELEMENT_ERROR}]
+ errors: [{messageId: 'passChildrenAsArgs'}]
},
{
code: '
;',
- errors: [{message: JSX_ERROR}]
+ errors: [{messageId: 'nestChildren'}]
},
{
code: 'React.createElement(MyComponent, {children: "Children", className: "class-name"});',
- errors: [{message: CREATE_ELEMENT_ERROR}]
+ errors: [{messageId: 'passChildrenAsArgs'}]
},
{
code: '
;',
- errors: [{message: JSX_ERROR}]
+ errors: [{messageId: 'nestChildren'}]
},
{
code: 'React.createElement(MyComponent, {...props, children: "Children"})',
- errors: [{message: CREATE_ELEMENT_ERROR}]
+ errors: [{messageId: 'passChildrenAsArgs'}]
}
]
});
diff --git a/tests/lib/rules/no-danger-with-children.js b/tests/lib/rules/no-danger-with-children.js
index eaf5af1638..cdfeaa3efa 100644
--- a/tests/lib/rules/no-danger-with-children.js
+++ b/tests/lib/rules/no-danger-with-children.js
@@ -106,25 +106,25 @@ ruleTester.run('no-danger-with-children', rule, {
Children