Skip to content

Commit 07a754f

Browse files
authored
Merge pull request #869 from julia-vscode/fix-jsonrpc-types
Replace single arg JSON RPC types
2 parents 8f5e881 + 67ebb64 commit 07a754f

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

src/extensions/messagedefs.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
const julia_getModuleAt_request_type = JSONRPC.RequestType("julia/getModuleAt", VersionedTextDocumentPositionParams, String)
22
const julia_getCurrentBlockRange_request_type = JSONRPC.RequestType("julia/getCurrentBlockRange", VersionedTextDocumentPositionParams, Position)
33
const julia_getDocAt_request_type = JSONRPC.RequestType("julia/getDocAt", VersionedTextDocumentPositionParams, String)
4-
const julia_getDocFromWord_request_type = JSONRPC.RequestType("julia/getDocFromWord", String, String)
4+
const julia_getDocFromWord_request_type = JSONRPC.RequestType("julia/getDocFromWord", NamedTuple{(:word,),Tuple{String}}, String)

src/protocol/messagedefs.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ const workspace_didChangeConfiguration_notification_type = JSONRPC.NotificationT
2222
const workspace_didChangeWorkspaceFolders_notification_type = JSONRPC.NotificationType("workspace/didChangeWorkspaceFolders", DidChangeWorkspaceFoldersParams)
2323
const workspace_applyEdit_request_type = JSONRPC.RequestType("workspace/applyEdit", ApplyWorkspaceEditParams, ApplyWorkspaceEditResponse)
2424
const workspace_configuration_request_type = JSONRPC.RequestType("workspace/configuration", ConfigurationParams, Vector{Any})
25-
const julia_activateenvironment_notification_type = JSONRPC.NotificationType("julia/activateenvironment", String)
25+
const julia_activateenvironment_notification_type = JSONRPC.NotificationType("julia/activateenvironment", NamedTuple{(:envPath,),Tuple{String}})
2626
const julia_refreshLanguageServer_notification_type = JSONRPC.NotificationType("julia/refreshLanguageServer", Nothing)
2727

2828
const initialize_request_type = JSONRPC.RequestType("initialize", InitializeParams, InitializeResult)

src/requests/features.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -397,10 +397,10 @@ function julia_getDocAt_request(params::VersionedTextDocumentPositionParams, ser
397397
end
398398

399399
# TODO: handle documentation resolving properly, respect how Documenter handles that
400-
function julia_getDocFromWord_request(word::String, server::LanguageServerInstance, conn)
400+
function julia_getDocFromWord_request(params::NamedTuple{(:word,),Tuple{String}}, server::LanguageServerInstance, conn)
401401
exact_matches = []
402402
approx_matches = []
403-
word_sym = Symbol(word)
403+
word_sym = Symbol(params.word)
404404
traverse_by_name(getsymbolserver(server)) do sym, val
405405
is_exact_match = sym === word_sym
406406
# this would ideally use the Damerau-Levenshtein distance or even something fancier:

src/requests/misc.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ function julia_getCurrentBlockRange_request(tdpp::VersionedTextDocumentPositionP
6666
return fallback
6767
end
6868

69-
function julia_activateenvironment_notification(params::String, server::LanguageServerInstance, conn)
70-
server.env_path = params
69+
function julia_activateenvironment_notification(params::NamedTuple{(:envPath,),Tuple{String}}, server::LanguageServerInstance, conn)
70+
server.env_path = params.envPath
7171

7272
trigger_symbolstore_reload(server)
7373
end

0 commit comments

Comments
 (0)