Merge pull request #994 from julia-vscode/sp/symbolserver-progress

Improve SymbolServer progress reporting

Author: pfitzseb

src/languageserverinstance.jl

@@ -147,7 +147,7 @@ function create_symserver_progress_ui(server)
         JSONRPC.send(
             server.jr_endpoint,
             progress_notification_type,
-            ProgressParams(token, WorkDoneProgressBegin("Julia Language Server", missing, "Indexing packages...", missing))
+            ProgressParams(token, WorkDoneProgressBegin("Julia", missing, "Starting async tasks...", 0))
         )
     end
 end
@@ -176,19 +176,20 @@ function trigger_symbolstore_reload(server::LanguageServerInstance)
     end
 
     @async try
-        # TODO Add try catch handler that links into crash reporting
         ssi_ret, payload = SymbolServer.getstore(
             server.symbol_server,
             server.env_path,
-            function (i)
+            function (msg, percentage = missing)
                 if server.clientcapability_window_workdoneprogress && server.current_symserver_progress_token !== nothing
+                    msg = ismissing(percentage) ? msg : string(msg, " ($percentage%)")
                     JSONRPC.send(
                         server.jr_endpoint,
                         progress_notification_type,
-                        ProgressParams(server.current_symserver_progress_token, WorkDoneProgressReport(missing, "Indexing $i...", missing))
+                        ProgressParams(server.current_symserver_progress_token, WorkDoneProgressReport(missing, msg, percentage))
                     )
+                    @info msg percentage
                 else
-                    @info "Indexing $i..."
+                    @info msg percentage
                 end
             end,
             server.err_handler,
@@ -349,9 +350,9 @@ function Base.run(server::LanguageServerInstance)
     msg_dispatcher[julia_getDocFromWord_request_type] = request_wrapper(julia_getDocFromWord_request, server)
     msg_dispatcher[textDocument_selectionRange_request_type] = request_wrapper(textDocument_selectionRange_request, server)
 
+    @debug "starting main loop"
     while true
         message = take!(server.combined_msg_queue)
-
         if message.type == :close
             @info "Shutting down server instance."
             return