Skip to content

Fix Bridge test for non-invertible constraint bridge #2713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
odow merged 5 commits into from
Apr 12, 2025
Merged

Fix Bridge test for non-invertible constraint bridge #2713

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc127e1
Fix Bridge test for non-invertible constraint bridge
blegat Apr 7, 2025
736ac60
Update docstring
blegat Apr 7, 2025
ee62a16
Fix format
blegat Apr 7, 2025
15241f6
Add test
blegat Apr 10, 2025
9b1d1f4
Add missing docstring
blegat Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test
  • Loading branch information
@blegat
blegat committed Apr 10, 2025
commit 15241f62889dd500c4692b1ec9d4968474fdaa74
25 changes: 25 additions & 0 deletions test/Bridges/set_map.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,15 @@ function MOI.Bridges.inverse_map_set(
return bridge.set
end

# Otherwise, it fails Bridges.runtests for `NOT_INVERTIBLE`
function MOI.supports(
::MOI.ModelLike,
::MOI.ConstraintDualStart,
::Type{<:ConstraintSwapBridge},
)
return false
end

const SwapBridge{T} = Union{VariableSwapBridge{T},ConstraintSwapBridge{T}}

function MOI.Bridges.map_function(bridge::SwapBridge, func)
Expand Down Expand Up @@ -214,6 +223,22 @@ function test_runtests()
MOI.add_constraint(model, func, set)
end,
)
MOI.Bridges.runtests(
ConstraintSwapBridge,
model -> begin
x = MOI.add_variables(model, 2)
func = MOI.VectorOfVariables(x)
set = SwapSet(do_swap, NOT_INVERTIBLE)
MOI.add_constraint(model, func, set)
end,
model -> begin
x = MOI.add_variables(model, 2)
func = MOI.VectorOfVariables(swap(x, do_swap))
set = MOI.Nonnegatives(2)
MOI.add_constraint(model, func, set)
end,
cannot_unbridge = true,
)
MOI.Bridges.runtests(
VariableSwapBridge,
model -> begin
Expand Down
Loading