Button will now be canceled in SortableContainer

Robin Franken · Robin Franken · commit aa1d5a4e5be4 · 2017-02-10T15:32:22.000+01:00
Added the buttuon to `shouldCancelStart` to allow buttons to be clicked within SortableContainers.
diff --git a/src/SortableContainer/index.js b/src/SortableContainer/index.js
@@ -37,7 +37,7 @@ export default function sortableContainer(WrappedComponent, config = {withRef: f
 			contentWindow: typeof window !== 'undefined' ? window : null,
 			shouldCancelStart: function (e) {
 				// Cancel sorting if the event target is an `input`, `textarea`, `select` or `option`
-				if (['input', 'textarea', 'select', 'option'].indexOf(e.target.tagName.toLowerCase()) !== -1) {
+				if (['input', 'textarea', 'select', 'option', 'button'].indexOf(e.target.tagName.toLowerCase()) !== -1) {
 					return true; // Return true to cancel sorting
 				}
 			},

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ export default function sortableContainer(WrappedComponent, config = {withRef: f`
`37`	`37`	`contentWindow: typeof window !== 'undefined' ? window : null,`
`38`	`38`	`shouldCancelStart: function (e) {`
`39`	`39`	// Cancel sorting if the event target is an `input`, `textarea`, `select` or `option`
`40`		`- if (['input', 'textarea', 'select', 'option'].indexOf(e.target.tagName.toLowerCase()) !== -1) {`
	`40`	`+ if (['input', 'textarea', 'select', 'option', 'button'].indexOf(e.target.tagName.toLowerCase()) !== -1) {`
`41`	`41`	`return true; // Return true to cancel sorting`
`42`	`42`	`}`
`43`	`43`	`},`